Skip to content

Conversation

@simon-debruijn
Copy link

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

  • Include id_token_hint in searchParams for endSessionUrl
  • Ran npm run pretty
  • This is a fix in behaviour and doesn't change any public or private api

📎 References

🎯 Testing

When triggering the logout handler you can verify if the id_token_hint search param is set during the redirect.
Before this change the id_token_hint was missing. it should be present now.

@simon-debruijn simon-debruijn requested a review from a team as a code owner October 16, 2024 09:31
@simon-debruijn simon-debruijn changed the title 1771 - Set idtokenhint when logging out 1771 - Set id_token_hint when logging out Oct 16, 2024
@simon-debruijn
Copy link
Author

Can someone review this please?

@frederikprijck
Copy link
Member

Hey, apologies for not getting back to you here, unsure why this was not replied to.

Few months have passed, forgive me for asking, is this still something you need in v3, knowing we have added support for this in v4?

If yes, I can help getting this PR in.

@simon-debruijn
Copy link
Author

Hey, apologies for not getting back to you here, unsure why this was not replied to.

Few months have passed, forgive me for asking, is this still something you need in v3, knowing we have added support for this in v4?

If yes, I can help getting this PR in.

Unfortunately the project where we need it still uses version 2.4. We're in the process of also upgrading react and nextjs versions. So at that point we can probably upgrade to v4 of nextjs-auth0.

cc @brampauwelyn What do you think?

tusharpandey13
tusharpandey13 previously approved these changes Jun 6, 2025
@tusharpandey13 tusharpandey13 changed the base branch from main to v3 June 6, 2025 09:13
@tusharpandey13 tusharpandey13 dismissed their stale review June 6, 2025 09:13

The base branch was changed.

@tusharpandey13
Copy link
Contributor

We need commits to be signed in order to merge contributor PRs. I've created a duplicate PR #2151 that contains all the commits from this PR, co-authored by me so that this change can be merged into v3 and a release be made.
Apologies for the late merge, we will merge these changes and make a v3 release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants