Skip to content

fix: re-enable async logging with proper shutdown flushing #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ivanauth wants to merge 1 commit into
base: main
Choose a base branch
from

fix: re-enable async logging with proper shutdown flushing

3b4d309
Select commit
Loading
Failed to load commit list.
Draft

fix: re-enable async logging with proper shutdown flushing #2779

fix: re-enable async logging with proper shutdown flushing
3b4d309
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Dec 17, 2025 in 1s

85.09% of diff hit (target 77.72%)

View this Pull Request on Codecov

85.09% of diff hit (target 77.72%)

Annotations

Check warning on line 22 in cmd/spicedb/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/spicedb/main.go#L22 

Added line #L22 was not covered by tests

Check warning on line 25 in cmd/spicedb/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/spicedb/main.go#L25 

Added line #L25 was not covered by tests

Check warning on line 33 in cmd/spicedb/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/spicedb/main.go#L31-L33 

Added lines #L31 - L33 were not covered by tests

Check warning on line 47 in cmd/spicedb/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/spicedb/main.go#L46-L47 

Added lines #L46 - L47 were not covered by tests

Check warning on line 56 in cmd/spicedb/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/spicedb/main.go#L56 

Added line #L56 was not covered by tests

Check warning on line 58 in cmd/spicedb/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/spicedb/main.go#L58 

Added line #L58 was not covered by tests

Check warning on line 61 in cmd/spicedb/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/spicedb/main.go#L61 

Added line #L61 was not covered by tests

Check warning on line 92 in internal/logging/logger.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/logging/logger.go#L92 

Added line #L92 was not covered by tests

Check warning on line 49 in pkg/cmd/server/logging_run_e.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/cmd/server/logging_run_e.go#L49 

Added line #L49 was not covered by tests

Check warning on line 71 in pkg/cmd/server/logging_run_e.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/cmd/server/logging_run_e.go#L70-L71 

Added lines #L70 - L71 were not covered by tests
View more details on Codecov