Skip to content

fix: re-enable async logging with proper shutdown flushing

3b4d309
Select commit
Loading
Failed to load commit list.
Draft

fix: re-enable async logging with proper shutdown flushing #2779

fix: re-enable async logging with proper shutdown flushing
3b4d309
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 17, 2025 in 0s

77.72% (target 75.00%)

View this Pull Request on Codecov

77.72% (target 75.00%)

Details

Codecov Report

❌ Patch coverage is 85.08772% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.72%. Comparing base (7519ee2) to head (3b4d309).

Files with missing lines Patch % Lines
cmd/spicedb/main.go 0.00% 10 Missing ⚠️
pkg/cmd/server/logging_run_e.go 88.89% 3 Missing and 2 partials ⚠️
internal/logging/logger.go 96.56% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2779      +/-   ##
==========================================
+ Coverage   77.72%   77.72%   +0.01%     
==========================================
  Files         472      473       +1     
  Lines       49716    49831     +115     
==========================================
+ Hits        38636    38728      +92     
- Misses       8228     8247      +19     
- Partials     2852     2856       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.