Skip to content

chore: enable QP consistency LR/LS tests unconditionally #2882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barakmich wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: enable QP consistency LR/LS tests unconditionally #2882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions internal/services/integrationtesting/query_plan_consistency_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ package integrationtesting_test
import (
"fmt"
"maps"
"os"
"path/filepath"
"slices"
"testing"
Expand Down Expand Up @@ -76,16 +75,10 @@ func runQueryPlanConsistencyForFile(t *testing.T, filePath string) {
runQueryPlanAssertions(t, handle)

t.Run("lookup_resources", func(t *testing.T) {
if os.Getenv("TEST_QUERY_PLAN_RESOURCES") == "" {
t.Skip("Skipping IterResources tests: set TEST_QUERY_PLAN_RESOURCES=true to enable")
}
runQueryPlanLookupResources(t, handle)
})

t.Run("lookup_subjects", func(t *testing.T) {
if os.Getenv("TEST_QUERY_PLAN_SUBJECTS") == "" {
t.Skip("Skipping IterSubjects tests: set TEST_QUERY_PLAN_SUBJECTS=true to enable")
}
runQueryPlanLookupSubjects(t, handle)
})
}
Expand Down Expand Up @@ -319,11 +312,6 @@ func testQueryPlanForEachResourceType(

// TestAccessibilitySetMethods tests the various methods of the AccessibilitySet
// to ensure they work correctly and provide code coverage.
//
// NOTE: This test exists to provide coverage for AccessibilitySet methods
// that are otherwise only exercised when TEST_QUERY_PLAN_RESOURCES or TEST_QUERY_PLAN_SUBJECTS
// environment flags are set. This test should be removed when those flags are removed and
// the corresponding tests run unconditionally.
func TestAccessibilitySetMethods(t *testing.T) {
t.Parallel()
require := require.New(t)
Expand Down
Loading