Skip to content

chore: enable QP consistency LR/LS tests unconditionally#2882

Open
barakmich wants to merge 1 commit intomainfrom
barakmich/enable_tests
Open

chore: enable QP consistency LR/LS tests unconditionally#2882
barakmich wants to merge 1 commit intomainfrom
barakmich/enable_tests

Conversation

@barakmich
Copy link
Contributor

Description

Testing

References

@barakmich barakmich requested a review from a team as a code owner February 5, 2026 18:24
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Feb 5, 2026
@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.95%. Comparing base (d842a97) to head (9e8b6e6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2882      +/-   ##
==========================================
- Coverage   74.85%   73.95%   -0.89%     
==========================================
  Files         484      484              
  Lines       58060    58060              
==========================================
- Hits        43455    42933     -522     
- Misses      11559    12071     +512     
- Partials     3046     3056      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barakmich barakmich force-pushed the barakmich/enable_tests branch from 4de5ebf to 9e8b6e6 Compare February 6, 2026 21:33
Copy link
Contributor

@miparnisari miparnisari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the tests panicked due to timeout:

panic: test timed out after 15m0s
	running tests:
		TestQueryPlanConsistency (13m26s)
		TestQueryPlanConsistency/lookupsametypes.yaml (4m10s)
		TestQueryPlanConsistency/lookupsametypes.yaml/lookup_resources/validate_lookup_resources_test/resource_view_ (4m9s)
		TestQueryPlanConsistency/lookupsametypes.yaml/lookup_resources/validate_lookup_resources_test/resource_view_/test/user:ceo (16s)
		TestQueryPlanConsistency/lookupsametypes.yaml/lookup_resources/validate_lookup_resources_test/usergroup_direct_member_ (4m9s)
		TestQueryPlanConsistency/lookupsametypes.yaml/lookup_resources/validate_lookup_resources_test/usergroup_direct_member_/test/user:an_eng_manager (4m9s)
		TestQueryPlanConsistency/lookupsametypes.yaml/lookup_resources/validate_lookup_resources_test/usergroup_manager_ (32s)
		TestQueryPlanConsistency/lookupsametypes.yaml/lookup_resources/validate_lookup_resources_test/usergroup_manager_/test/user:an_eng_manager (32s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants