chore(datastore): Change the DatastoreTester interface to take a testing.TB#2925
Merged
chore(datastore): Change the DatastoreTester interface to take a testing.TB#2925
Conversation
github-actions
bot
added
area/datastore
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Member
josephschorr
left a comment
josephschorr
left a comment
There was a problem hiding this comment.
You'll need to update the CHANGLOG as well
Member
Author
|
I have read the CLA Document and I hereby sign the CLA |
authzedbot
added a commit
to authzed/cla
that referenced
this pull request
Feb 27, 2026
jakedt
force-pushed
the
datastore-tester-interface
branch
from
4e3ba89 to
325da5e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (74.53%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2925 +/- ##
==========================================
+ Coverage 73.57% 74.53% +0.96%
==========================================
Files 489 489
Lines 60373 60373
==========================================
+ Hits 44414 44990 +576
+ Misses 12798 12232 -566
+ Partials 3161 3151 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ing.TB for per-test cleanup.
jakedt
force-pushed
the
datastore-tester-interface
branch
from
325da5e to
7a19dda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change allows us to (optionally) cleanup datastore instances on a per-test basis, rather than waiting for the whole test suite to finish.