Skip to content

chore(datastore): Change the DatastoreTester interface to take a testing.TB #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakedt merged 1 commit into from
Feb 27, 2026
Merged

chore(datastore): Change the DatastoreTester interface to take a testing.TB #2925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Begin deprecation of library "github.com/dlmiddlecote/sqlstats" (https://github.com/authzed/spicedb/pull/2904).
NOTE: in a future release, MySQL metrics will change.
- Add support for imports and partials to the schemadsl package that drives the LSP and development server (https://github.com/authzed/spicedb/pull/2919).
- `DatastoreTester.New` now takes a `testing.TB` as its first argument, allowing per-test cleanup in datastore test suites (https://github.com/authzed/spicedb/pull/2925).

### Fixed
- enforce graceful shutdown on serve and serve-testing (https://github.com/authzed/spicedb/pull/2888)
Expand Down
12 changes: 6 additions & 6 deletions internal/datastore/crdb/crdb_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func crdbTestVersion() string {
func TestCRDBDatastoreWithoutIntegrity(t *testing.T) {
t.Parallel()
b := testdatastore.RunCRDBForTesting(t, "", crdbTestVersion())
test.All(t, test.DatastoreTesterFunc(func(revisionQuantization, gcInterval, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
test.All(t, test.DatastoreTesterFunc(func(_ testing.TB, revisionQuantization, gcInterval, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
ctx := context.Background()
ds := b.NewDatastore(t, func(engine, uri string) datastore.Datastore {
ds, err := NewCRDBDatastore(
Expand Down Expand Up @@ -202,7 +202,7 @@ func TestCRDBDatastoreWithIntegrity(t *testing.T) { //nolint:tparallel
t.Parallel()
b := testdatastore.RunCRDBForTesting(t, "", crdbTestVersion())

test.All(t, test.DatastoreTesterFunc(func(revisionQuantization, gcInterval, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
test.All(t, test.DatastoreTesterFunc(func(_ testing.TB, revisionQuantization, gcInterval, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
ctx := context.Background()
ds := b.NewDatastore(t, func(engine, uri string) datastore.Datastore {
ds, err := NewCRDBDatastore(
Expand All @@ -229,7 +229,7 @@ func TestCRDBDatastoreWithIntegrity(t *testing.T) { //nolint:tparallel
return ds, nil
}), false)

unwrappedTester := test.DatastoreTesterFunc(func(revisionQuantization, gcInterval, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
unwrappedTester := test.DatastoreTesterFunc(func(_ testing.TB, revisionQuantization, gcInterval, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
ctx := context.Background()
ds := b.NewDatastore(t, func(engine, uri string) datastore.Datastore {
ds, err := NewCRDBDatastore(
Expand Down Expand Up @@ -505,7 +505,7 @@ func newCRDBWithUser(t *testing.T, pool *dockertest.Pool) (adminConn *pgx.Conn,
func RelationshipIntegrityInfoTest(t *testing.T, tester test.DatastoreTester) {
require := require.New(t)

rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
rawDS, err := tester.New(t, 0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(err)

ds, _ := testfixtures.StandardDatastoreWithSchema(rawDS, require)
Expand Down Expand Up @@ -568,7 +568,7 @@ func (f *fakeSource) Next(ctx context.Context) (*tuple.Relationship, error) {
func BulkRelationshipIntegrityInfoTest(t *testing.T, tester test.DatastoreTester) {
require := require.New(t)

rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
rawDS, err := tester.New(t, 0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(err)

ds, _ := testfixtures.StandardDatastoreWithSchema(rawDS, require)
Expand Down Expand Up @@ -617,7 +617,7 @@ func BulkRelationshipIntegrityInfoTest(t *testing.T, tester test.DatastoreTester
func RelationshipIntegrityWatchTest(t *testing.T, tester test.DatastoreTester) {
require := require.New(t)

rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
rawDS, err := tester.New(t, 0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(err)

ds, rev := testfixtures.StandardDatastoreWithSchema(rawDS, require)
Expand Down
2 changes: 1 addition & 1 deletion internal/datastore/memdb/memdb_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (

type memDBTest struct{}

func (mdbt memDBTest) New(revisionQuantization, _, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
func (mdbt memDBTest) New(_ testing.TB, revisionQuantization, _, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
return NewMemdbDatastore(watchBufferLength, revisionQuantization, gcWindow)
}

Expand Down
11 changes: 5 additions & 6 deletions internal/datastore/mysql/datastore_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,12 @@ func (mds *mysqlDatastore) ExampleRetryableError() error {

type datastoreTester struct {
b testdatastore.RunningEngineForTest
t *testing.T
prefix string
}

func (dst *datastoreTester) createDatastore(revisionQuantization, gcInterval, gcWindow time.Duration, _ uint16) (datastore.Datastore, error) {
func (dst *datastoreTester) createDatastore(tb testing.TB, revisionQuantization, gcInterval, gcWindow time.Duration, _ uint16) (datastore.Datastore, error) {
ctx := context.Background()
ds := dst.b.NewDatastore(dst.t, func(engine, uri string) datastore.Datastore {
ds := dst.b.NewDatastore(tb, func(engine, uri string) datastore.Datastore {
ds, err := newMySQLDatastore(ctx, uri, primaryInstanceID,
RevisionQuantization(revisionQuantization),
GCWindow(gcWindow),
Expand All @@ -56,11 +55,11 @@ func (dst *datastoreTester) createDatastore(revisionQuantization, gcInterval, gc
DebugAnalyzeBeforeStatistics(),
OverrideLockWaitTimeout(1),
)
require.NoError(dst.t, err)
require.NoError(tb, err)
return indexcheck.WrapWithIndexCheckingDatastoreProxyIfApplicable(ds)
})
_, err := ds.ReadyState(context.Background())
require.NoError(dst.t, err)
require.NoError(tb, err)
return ds, nil
}

Expand Down Expand Up @@ -123,7 +122,7 @@ func TestMySQLDatastoreDSNWithoutParseTime(t *testing.T) {

func TestMySQL8Datastore(t *testing.T) {
b := testdatastore.RunMySQLForTestingWithOptions(t, testdatastore.MySQLTesterOptions{MigrateForNewDatastore: true}, "")
dst := datastoreTester{b: b, t: t}
dst := datastoreTester{b: b}
test.AllWithExceptions(t, test.DatastoreTesterFunc(dst.createDatastore), test.WithCategories(test.WatchSchemaCategory, test.WatchCheckpointsCategory), true)
additionalMySQLTests(t, b)
}
Expand Down
8 changes: 4 additions & 4 deletions internal/datastore/postgres/postgres_shared_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func testPostgresDatastore(t *testing.T, config postgresTestConfig) {
ctx := context.Background()

// NOTE: gc tests take exclusive locks, so they are run under non-parallel.
test.OnlyGCTests(t, test.DatastoreTesterFunc(func(revisionQuantization, gcInterval, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
test.OnlyGCTests(t, test.DatastoreTesterFunc(func(_ testing.TB, revisionQuantization, gcInterval, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
ds := b.NewDatastore(t, func(engine, uri string) datastore.Datastore {
ds, err := newPostgresDatastore(ctx, uri, primaryInstanceID,
RevisionQuantization(revisionQuantization),
Expand Down Expand Up @@ -119,7 +119,7 @@ func testPostgresDatastore(t *testing.T, config postgresTestConfig) {
b := testdatastore.RunPostgresForTesting(t, "", config.targetMigration, config.pgVersion, config.pgbouncer)
ctx := context.Background()

test.AllWithExceptions(t, test.DatastoreTesterFunc(func(revisionQuantization, _, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
test.AllWithExceptions(t, test.DatastoreTesterFunc(func(_ testing.TB, revisionQuantization, _, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
ds := b.NewDatastore(t, func(engine, uri string) datastore.Datastore {
ds, err := newPostgresDatastore(ctx, uri, primaryInstanceID,
RevisionQuantization(revisionQuantization),
Expand Down Expand Up @@ -318,7 +318,7 @@ func testPostgresDatastoreWithoutCommitTimestamps(t *testing.T, config postgresT

// NOTE: watch API requires the commit timestamps, so we skip those tests here.
// NOTE: gc tests take exclusive locks, so they are run under non-parallel.
test.AllWithExceptions(t, test.DatastoreTesterFunc(func(revisionQuantization, _, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
test.AllWithExceptions(t, test.DatastoreTesterFunc(func(_ testing.TB, revisionQuantization, _, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
ds := b.NewDatastore(t, func(engine, uri string) datastore.Datastore {
ds, err := newPostgresDatastore(ctx, uri, primaryInstanceID,
RevisionQuantization(revisionQuantization),
Expand All @@ -338,7 +338,7 @@ func testPostgresDatastoreWithoutCommitTimestamps(t *testing.T, config postgresT
t.Run(fmt.Sprintf("postgres-%s-gc", pgVersion), func(t *testing.T) {
ctx := context.Background()
b := testdatastore.RunPostgresForTestingWithCommitTimestamps(t, "", "head", false, pgVersion, enablePgbouncer)
test.OnlyGCTests(t, test.DatastoreTesterFunc(func(revisionQuantization, gcInterval, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
test.OnlyGCTests(t, test.DatastoreTesterFunc(func(_ testing.TB, revisionQuantization, gcInterval, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
ds := b.NewDatastore(t, func(engine, uri string) datastore.Datastore {
ds, err := newPostgresDatastore(ctx, uri, primaryInstanceID,
RevisionQuantization(revisionQuantization),
Expand Down
10 changes: 4 additions & 6 deletions internal/datastore/proxy/observable_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,18 @@ import (
"github.com/authzed/spicedb/pkg/datastore/test"
)

type observableTest struct {
t *testing.T
}
type observableTest struct{}

func (obs observableTest) New(revisionQuantization, _, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
db, err := dsfortesting.NewMemDBDatastoreForTesting(obs.t, watchBufferLength, revisionQuantization, gcWindow)
func (obs observableTest) New(tb testing.TB, revisionQuantization, _, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
db, err := dsfortesting.NewMemDBDatastoreForTesting(tb, watchBufferLength, revisionQuantization, gcWindow)
if err != nil {
return nil, err
}
return NewObservableDatastoreProxy(db), nil
}

func TestObservableProxy(t *testing.T) {
test.All(t, observableTest{t}, true)
test.All(t, observableTest{}, true)
}

func (p *observableProxy) ExampleRetryableError() error {
Expand Down
2 changes: 1 addition & 1 deletion internal/datastore/spanner/spanner_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func TestSpannerDatastore(t *testing.T) {
b := testdatastore.RunSpannerForTesting(t, "", "head")

// Transaction tests are excluded because, for reasons unknown, one cannot read its own write in one transaction in the Spanner emulator.
test.AllWithExceptions(t, test.DatastoreTesterFunc(func(revisionQuantization, _, _ time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
test.AllWithExceptions(t, test.DatastoreTesterFunc(func(_ testing.TB, revisionQuantization, _, _ time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
ds := b.NewDatastore(t, func(engine, uri string) datastore.Datastore {
ds, err := NewSpannerDatastore(ctx, uri,
RevisionQuantization(revisionQuantization),
Expand Down
6 changes: 3 additions & 3 deletions pkg/datastore/test/basic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ func UseAfterCloseTest(t *testing.T, tester DatastoreTester) {
require := require.New(t)

// Create the datastore.
ds, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
ds, err := tester.New(t, 0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(err)

// Immediately close it.
Expand All @@ -28,7 +28,7 @@ func UseAfterCloseTest(t *testing.T, tester DatastoreTester) {
}

func DeleteAllDataTest(t *testing.T, tester DatastoreTester) {
rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
rawDS, err := tester.New(t, 0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(t, err)

ds, revision := testfixtures.StandardDatastoreWithCaveatedData(rawDS, require.New(t))
Expand Down Expand Up @@ -87,7 +87,7 @@ func UniqueIDTest(t *testing.T, tester DatastoreTester) {
require := require.New(t)

// Create the datastore.
ds, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
ds, err := tester.New(t, 0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(err)

// Ensure the unique ID is not empty.
Expand Down
14 changes: 7 additions & 7 deletions pkg/datastore/test/bulk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ func BulkUploadTest(t *testing.T, tester DatastoreTester) {
require := require.New(t)
ctx := t.Context()

rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
rawDS, err := tester.New(t, 0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(err)

ds, _ := testfixtures.StandardDatastoreWithSchema(rawDS, require)
Expand Down Expand Up @@ -68,7 +68,7 @@ func BulkUploadErrorsTest(t *testing.T, tester DatastoreTester) {
require := require.New(t)
ctx := t.Context()

rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
rawDS, err := tester.New(t, 0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(err)

ds, _ := testfixtures.StandardDatastoreWithSchema(rawDS, require)
Expand All @@ -88,7 +88,7 @@ func BulkUploadAlreadyExistsSameCallErrorTest(t *testing.T, tester DatastoreTest
require := require.New(t)
ctx := t.Context()

rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
rawDS, err := tester.New(t, 0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(err)

ds, _ := testfixtures.StandardDatastoreWithSchema(rawDS, require)
Expand Down Expand Up @@ -127,7 +127,7 @@ func BulkUploadWithCaveats(t *testing.T, tester DatastoreTester) {
require := require.New(t)
ctx := t.Context()

rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
rawDS, err := tester.New(t, 0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(err)

ds, _ := testfixtures.StandardDatastoreWithSchema(rawDS, require)
Expand Down Expand Up @@ -169,7 +169,7 @@ func BulkUploadWithExpiration(t *testing.T, tester DatastoreTester) {
require := require.New(t)
ctx := t.Context()

rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
rawDS, err := tester.New(t, 0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(err)

ds, _ := testfixtures.StandardDatastoreWithSchema(rawDS, require)
Expand Down Expand Up @@ -207,7 +207,7 @@ func BulkUploadEditCaveat(t *testing.T, tester DatastoreTester) {
require := require.New(t)
ctx := t.Context()

rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
rawDS, err := tester.New(t, 0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(err)

ds, _ := testfixtures.StandardDatastoreWithSchema(rawDS, require)
Expand Down Expand Up @@ -273,7 +273,7 @@ func BulkUploadAlreadyExistsErrorTest(t *testing.T, tester DatastoreTester) {
require := require.New(t)
ctx := t.Context()

rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
rawDS, err := tester.New(t, 0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(err)

ds, _ := testfixtures.StandardDatastoreWithSchema(rawDS, require)
Expand Down
12 changes: 6 additions & 6 deletions pkg/datastore/test/caveat.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import (
func CaveatNotFoundTest(t *testing.T, tester DatastoreTester) {
require := require.New(t)

ds, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
ds, err := tester.New(t, 0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(err)

ctx := t.Context()
Expand All @@ -42,7 +42,7 @@ func CaveatNotFoundTest(t *testing.T, tester DatastoreTester) {

func WriteReadDeleteCaveatTest(t *testing.T, tester DatastoreTester) {
req := require.New(t)
ds, err := tester.New(0*time.Second, veryLargeGCInterval, veryLargeGCWindow, 1)
ds, err := tester.New(t, 0*time.Second, veryLargeGCInterval, veryLargeGCWindow, 1)
req.NoError(err)

skipIfNotCaveatStorer(t, ds)
Expand Down Expand Up @@ -129,7 +129,7 @@ func WriteReadDeleteCaveatTest(t *testing.T, tester DatastoreTester) {

func WriteCaveatedRelationshipTest(t *testing.T, tester DatastoreTester) {
req := require.New(t)
ds, err := tester.New(0*time.Second, veryLargeGCInterval, veryLargeGCWindow, 1)
ds, err := tester.New(t, 0*time.Second, veryLargeGCInterval, veryLargeGCWindow, 1)
req.NoError(err)

skipIfNotCaveatStorer(t, ds)
Expand Down Expand Up @@ -205,7 +205,7 @@ func WriteCaveatedRelationshipTest(t *testing.T, tester DatastoreTester) {

func CaveatedRelationshipFilterTest(t *testing.T, tester DatastoreTester) {
req := require.New(t)
ds, err := tester.New(0*time.Second, veryLargeGCInterval, veryLargeGCWindow, 1)
ds, err := tester.New(t, 0*time.Second, veryLargeGCInterval, veryLargeGCWindow, 1)
req.NoError(err)

skipIfNotCaveatStorer(t, ds)
Expand Down Expand Up @@ -254,7 +254,7 @@ func CaveatedRelationshipFilterTest(t *testing.T, tester DatastoreTester) {

func CaveatSnapshotReadsTest(t *testing.T, tester DatastoreTester) {
req := require.New(t)
ds, err := tester.New(0*time.Second, veryLargeGCInterval, veryLargeGCWindow, 1)
ds, err := tester.New(t, 0*time.Second, veryLargeGCInterval, veryLargeGCWindow, 1)
req.NoError(err)

skipIfNotCaveatStorer(t, ds)
Expand Down Expand Up @@ -287,7 +287,7 @@ func CaveatSnapshotReadsTest(t *testing.T, tester DatastoreTester) {

func CaveatedRelationshipWatchTest(t *testing.T, tester DatastoreTester) {
req := require.New(t)
ds, err := tester.New(0*time.Second, veryLargeGCInterval, veryLargeGCWindow, 16)
ds, err := tester.New(t, 0*time.Second, veryLargeGCInterval, veryLargeGCWindow, 16)
req.NoError(err)

skipIfNotCaveatStorer(t, ds)
Expand Down
10 changes: 5 additions & 5 deletions pkg/datastore/test/counters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (
)

func RelationshipCounterOverExpiredTest(t *testing.T, tester DatastoreTester) {
rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
rawDS, err := tester.New(t, 0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(t, err)

ds, _ := testfixtures.StandardDatastoreWithData(rawDS, require.New(t))
Expand Down Expand Up @@ -69,7 +69,7 @@ func RelationshipCounterOverExpiredTest(t *testing.T, tester DatastoreTester) {
}

func RegisterRelationshipCountersInParallelTest(t *testing.T, tester DatastoreTester) {
rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
rawDS, err := tester.New(t, 0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(t, err)

ds, _ := testfixtures.StandardDatastoreWithData(rawDS, require.New(t))
Expand Down Expand Up @@ -112,7 +112,7 @@ func RegisterRelationshipCountersInParallelTest(t *testing.T, tester DatastoreTe
}

func RelationshipCountersTest(t *testing.T, tester DatastoreTester) {
rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
rawDS, err := tester.New(t, 0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(t, err)

ds, rev := testfixtures.StandardDatastoreWithData(rawDS, require.New(t))
Expand Down Expand Up @@ -215,7 +215,7 @@ func RelationshipCountersTest(t *testing.T, tester DatastoreTester) {
}

func RelationshipCountersWithOddFilterTest(t *testing.T, tester DatastoreTester) {
rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
rawDS, err := tester.New(t, 0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(t, err)
ds, _ := testfixtures.StandardDatastoreWithData(rawDS, require.New(t))

Expand Down Expand Up @@ -257,7 +257,7 @@ func RelationshipCountersWithOddFilterTest(t *testing.T, tester DatastoreTester)
}

func UpdateRelationshipCounterTest(t *testing.T, tester DatastoreTester) {
rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
rawDS, err := tester.New(t, 0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(t, err)

ds, rev := testfixtures.StandardDatastoreWithData(rawDS, require.New(t))
Expand Down
Loading
Loading