Skip to content

fix: do not register CRDB metrics in init() #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
miparnisari wants to merge 1 commit into
base: main
Choose a base branch
from

fix: do not register CRDB metrics in init()

eedc13b
Select commit
Loading
Failed to load commit list.
Draft

fix: do not register CRDB metrics in init() #2966

fix: do not register CRDB metrics in init()
eedc13b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 11, 2026 in 1s

46.02% (target 75.00%)

View this Pull Request on Codecov

46.02% (target 75.00%)

Details

Codecov Report

❌ Patch coverage is 72.41379% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.02%. Comparing base (0e16dd1) to head (eedc13b).

Files with missing lines Patch % Lines
...nal/datastore/proxy/schemacaching/watchingcache.go 0.00% 8 Missing ⚠️
internal/datastore/crdb/pool/balancer.go 85.30% 5 Missing ⚠️
internal/datastore/crdb/pool/health.go 75.00% 3 Missing and 1 partial ⚠️
internal/datastore/crdb/pool/pool.go 73.34% 3 Missing and 1 partial ⚠️
internal/datastore/crdb/crdb.go 78.58% 3 Missing ⚠️

❌ Your project check has failed because the head coverage (46.02%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2966      +/-   ##
==========================================
- Coverage   48.88%   46.02%   -2.86%     
==========================================
  Files         429      429              
  Lines       54628    54687      +59     
==========================================
- Hits        26700    25163    -1537     
- Misses      25220    26881    +1661     
+ Partials     2708     2643      -65

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov