Skip to content
This repository was archived by the owner on Mar 10, 2023. It is now read-only.

Comments

Optimized pixel_cloud_fusion by eliminating unnecessary iterations#64

Open
yucedagonurcan wants to merge 1 commit intoautowarefoundation:masterfrom
yucedagonurcan:master
Open

Optimized pixel_cloud_fusion by eliminating unnecessary iterations#64
yucedagonurcan wants to merge 1 commit intoautowarefoundation:masterfrom
yucedagonurcan:master

Conversation

@yucedagonurcan
Copy link

Bug fix

  • Related issue: Pixel Cloud Fusion Unnecessary Iterations #63

  • Problem is that we are not correctly utilizing this for loop:

    • orig_iteration_part
  • Let's see how much we are utilizing the loop:

    • =================================================
    • All Pixels to Count(Width x Height or 1440 x 928): 1336320
    • Pixels that We Care(projection_map_.size()): 14416
    • Utilization(All Pixels to Count / Pixels that We Care): %1.07878
    • ==================================================
  • Also I have the running average of the iteration part with the help of the swri_profiler:

    • profiling_iteration_part
    • As you can see it takes around 385ms on average.
      • image

Fix applied

  • We can iterate through all the key – value pairs of the map object itself.
    • solution_iteration_part
    • Let's see the profiling results, as you can see improvement is from 385ms to 342microseconds.
      • image

New feature implementation

Implementation description

Signed-off-by: onur@adastec.com <onur@adastec.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant