Skip to content

feat(autoware_planning_rviz_plugin): add pose visualization as an arrow#27

Open
ralwing wants to merge 6 commits intoautowarefoundation:mainfrom
AutonomousSystemsPL:trajectory-pose
Open

feat(autoware_planning_rviz_plugin): add pose visualization as an arrow#27
ralwing wants to merge 6 commits intoautowarefoundation:mainfrom
AutonomousSystemsPL:trajectory-pose

Conversation

@ralwing
Copy link
Copy Markdown

@ralwing ralwing commented Nov 18, 2025

Description

This PR adds trajectory pose visualization as an arrow which shaft starts in the pose.position and directed by pose.orientation

Screenshot from 2025-11-18 08-54-50 image

How was this PR tested?

Tested in rviz.

Copilot AI review requested due to automatic review settings November 18, 2025 07:52
@ralwing ralwing requested review from a team, takayuki5168 and yukkysaito as code owners November 18, 2025 07:52
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 18, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds pose visualization as arrows to the Autoware planning RViz plugin, displaying trajectory pose directions with configurable arrow markers that originate from pose positions and are oriented by pose orientations.

  • Adds new properties for pose visualization: view toggle, alpha, color, arrow length, and offset
  • Implements arrow rendering using triangle geometry with shaft and head
  • Integrates pose visualization into existing path footprint rendering loop

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…s and rendering

Signed-off-by: Grzegorz Głowacki <gglowacki@autonomous-systems.pl>
ralwing and others added 5 commits November 18, 2025 15:42
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Grzegorz Głowacki <gglowacki@autonomous-systems.pl>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Grzegorz Głowacki <gglowacki@autonomous-systems.pl>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Grzegorz Głowacki <gglowacki@autonomous-systems.pl>
… visibility

Signed-off-by: Grzegorz Głowacki <gglowacki@autonomous-systems.pl>
Signed-off-by: Grzegorz Głowacki <gglowacki@autonomous-systems.pl>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +656 to +663
const double p0_x = origin_x - shaft_width / 2.0 * sin_yaw;
const double p0_y = origin_y + shaft_width / 2.0 * cos_yaw;
const double p1_x = origin_x + shaft_width / 2.0 * sin_yaw;
const double p1_y = origin_y - shaft_width / 2.0 * cos_yaw;
const double p2_x = origin_x + shaft_length * cos_yaw + shaft_width / 2.0 * sin_yaw;
const double p2_y = origin_y + shaft_length * sin_yaw - shaft_width / 2.0 * cos_yaw;
const double p3_x = origin_x + shaft_length * cos_yaw - shaft_width / 2.0 * sin_yaw;
const double p3_y = origin_y + shaft_length * sin_yaw + shaft_width / 2.0 * cos_yaw;
Copy link

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The arrow geometry calculations use repeated expressions like 'shaft_width / 2.0 * sin_yaw' and 'shaft_width / 2.0 * cos_yaw'. Extract these as named constants (e.g., 'half_shaft_width_perp_x' and 'half_shaft_width_perp_y') to improve readability and reduce potential errors from repeated calculations.

Suggested change
const double p0_x = origin_x - shaft_width / 2.0 * sin_yaw;
const double p0_y = origin_y + shaft_width / 2.0 * cos_yaw;
const double p1_x = origin_x + shaft_width / 2.0 * sin_yaw;
const double p1_y = origin_y - shaft_width / 2.0 * cos_yaw;
const double p2_x = origin_x + shaft_length * cos_yaw + shaft_width / 2.0 * sin_yaw;
const double p2_y = origin_y + shaft_length * sin_yaw - shaft_width / 2.0 * cos_yaw;
const double p3_x = origin_x + shaft_length * cos_yaw - shaft_width / 2.0 * sin_yaw;
const double p3_y = origin_y + shaft_length * sin_yaw + shaft_width / 2.0 * cos_yaw;
const double half_shaft_width_perp_x = shaft_width / 2.0 * sin_yaw;
const double half_shaft_width_perp_y = shaft_width / 2.0 * cos_yaw;
const double p0_x = origin_x - half_shaft_width_perp_x;
const double p0_y = origin_y + half_shaft_width_perp_y;
const double p1_x = origin_x + half_shaft_width_perp_x;
const double p1_y = origin_y - half_shaft_width_perp_y;
const double p2_x = origin_x + shaft_length * cos_yaw + half_shaft_width_perp_x;
const double p2_y = origin_y + shaft_length * sin_yaw - half_shaft_width_perp_y;
const double p3_x = origin_x + shaft_length * cos_yaw - half_shaft_width_perp_x;
const double p3_y = origin_y + shaft_length * sin_yaw + half_shaft_width_perp_y;

Copilot uses AI. Check for mistakes.
@ralwing
Copy link
Copy Markdown
Author

ralwing commented Feb 13, 2026

@yukkysaito i'm kindly pinging ;-)

@yukkysaito
Copy link
Copy Markdown
Contributor

I have already approved it, but it looks like the CI hasn’t passed. I’ve re-triggered the CI, so please wait a moment.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 0% with 57 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@bac3843). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...utoware_planning_rviz_plugin/path/display_base.hpp 0.00% 57 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             main     #27   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?      12           
  Lines           ?    1426           
  Branches        ?     168           
======================================
  Hits            ?       0           
  Misses          ?    1426           
  Partials        ?       0           
Flag Coverage Δ
differential 0.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ralwing
Copy link
Copy Markdown
Author

ralwing commented Mar 10, 2026

@yukkysaito friendly ping ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants