feat: enable pcd divider to generate a metadat file#252
feat: enable pcd divider to generate a metadat file#252anhnv3991 wants to merge 15 commits intoautowarefoundation:mainfrom
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
|
This is a package intended for dividing map point clouds, |
|
You should consider refactoring the code into a library so that both |
I agree that the point cloud divider should divide a map into actuall PCD files. But we don't always want to process maps at point-level. If we examine maps at the segment-level, the metadata is enough. The TP manager now is checking Tps of map segments, so no need to actually divide map points. I want to keep all the operations related to hashing points, finding segments, and distributing points to segments in a single package. So adding a parameter to generate a metadata file without dividing points is enough, imo. |
I will consider this when there are more than two packages that call point cloud divider's functionality. Currently, adding one parameter and call the pcd divider via a python's call is simpler. |
It's best to stop using it like that, as it makes no sense. |
Signed-off-by: Anh Nguyen <anh.nguyen.2@tier4.jp>
Signed-off-by: Anh Nguyen <anh.nguyen.2@tier4.jp>
Signed-off-by: Anh Nguyen <anh.nguyen.2@tier4.jp>
Signed-off-by: Anh Nguyen <anh.nguyen.2@tier4.jp>
Signed-off-by: Anh Nguyen <anh.nguyen.2@tier4.jp>
…e meta_generator function. Signed-off-by: Anh Nguyen <anh.nguyen.2@tier4.jp>
Signed-off-by: Anh Nguyen <anh.nguyen.2@tier4.jp>
Signed-off-by: Anh Nguyen <anh.nguyen.2@tier4.jp>
Signed-off-by: Anh Nguyen <anh.nguyen.2@tier4.jp>
96a873f to
c3f3f77
Compare
…cripts Signed-off-by: Anh Nguyen <anh.nguyen.2@tier4.jp>
Signed-off-by: Anh Nguyen <anh.nguyen.2@tier4.jp>
Description
How was this PR tested?
ros2 launch autoware_pointcloud_divider pointcloud_divider.launch.xml input_pcd_or_dir:=<map_path> output_pcd_dir:=<output_folder> grid_size_x:=2.0 grid_size_y:=2.0 metadata_generate:=trueNotes for reviewers
None.
Effects on system behavior
None.