Skip to content

fix: correct argparse variable names in DomainSeg video_visualization#259

Merged
m-zain-khawaja merged 1 commit intoautowarefoundation:mainfrom
ThomasLin617:fix-domainseg-argparse
Mar 11, 2026
Merged

fix: correct argparse variable names in DomainSeg video_visualization#259
m-zain-khawaja merged 1 commit intoautowarefoundation:mainfrom
ThomasLin617:fix-domainseg-argparse

Conversation

@ThomasLin617
Copy link
Contributor

This PR fixes a variable name mismatch in
Models/visualizations/DomainSeg/video_visualization.py.

The argparse definitions specify the following destinations:

  • input_video_filepath
  • output_video_filepath

However, the script references non-existent attributes:

  • args.video_filepath
  • args.output_file

This results in an AttributeError when running the script.

This patch updates the variable references to match the argparse
definitions:

  • args.video_filepath → args.input_video_filepath
  • args.output_file → args.output_video_filepath

@ThomasLin617 ThomasLin617 changed the title Fix argparse variable mismatch in DomainSeg video_visualization script fix: correct argparse variable names in DomainSeg video_visualization Mar 9, 2026
Signed-off-by: ThomasLin617 <thomaslin617@gmail.com>
@ThomasLin617 ThomasLin617 force-pushed the fix-domainseg-argparse branch from f165a79 to 7e312cb Compare March 9, 2026 08:16
Copy link
Member

@m-zain-khawaja m-zain-khawaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - thanks @ThomasLin617

@m-zain-khawaja m-zain-khawaja merged commit 2aca9c7 into autowarefoundation:main Mar 11, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants