Check that custom dependency version is at least equal to min version defined in latest.json

cmd/blockchaincmd/convert.go

@@ -193,6 +193,9 @@ func StartLocalMachine(
 		avagoVersionSettings := dependencies.AvalancheGoVersionSettings{}
 		// setup (install if needed) avalanchego binary
 		avagoVersion := userProvidedAvagoVersion
+		if err = dependencies.CheckVersionIsOverMin(app, constants.AvalancheGoRepoName, network, userProvidedAvagoVersion); err != nil {
+			return false, err
+		}
 		if userProvidedAvagoVersion == constants.DefaultAvalancheGoVersion && avagoBinaryPath == "" {
 			// nothing given: get avago version from RPC compat using latest.json defined in
 			// https://raw.githubusercontent.com/ava-labs/avalanche-cli/control-default-version/versions/latest.json

cmd/blockchaincmd/deploy.go

@@ -483,9 +483,7 @@ func deployBlockchain(cmd *cobra.Command, args []string) error {
 
 	if network.Kind == models.Local {
 		app.Log.Debug("Deploy local")
-
 		avagoVersion := userProvidedAvagoVersion
-
 		if avagoVersion == constants.DefaultAvalancheGoVersion && avagoBinaryPath == "" {
 			avagoVersion, err = dependencies.GetLatestCLISupportedDependencyVersion(app, constants.AvalancheGoRepoName, network, &sidecar.RPCVersion)
 			if err != nil {

cmd/nodecmd/create.go

@@ -135,8 +135,13 @@ will apply to all nodes in the cluster`,
 // override postrun function from root.go, so that we don't double send metrics for the same command
 func handlePostRun(_ *cobra.Command, _ []string) {}
 
-func preCreateChecks(clusterName string) error {
+func preCreateChecks(clusterName string, network models.Network) error {
 	if useCustomAvalanchegoVersion != "" || useAvalanchegoVersionFromSubnet != "" {
+		if useCustomAvalanchegoVersion != "" {
+			if err := dependencies.CheckVersionIsOverMin(app, constants.AvalancheGoRepoName, network, useCustomAvalanchegoVersion); err != nil {
+				return err
+			}
+		}
 		useLatestAvalanchegoReleaseVersion = false
 		useLatestAvalanchegoPreReleaseVersion = false
 	}
@@ -305,7 +310,7 @@ func createNodes(cmd *cobra.Command, args []string) error {
 		"",
 	)
 	setGlobalNetworkFlags(network)
-	if err := preCreateChecks(clusterName); err != nil {
+	if err := preCreateChecks(clusterName, network); err != nil {
 		return err
 	}
 	network = models.NewNetworkFromCluster(network, clusterName)

cmd/nodecmd/local.go

@@ -247,6 +247,10 @@ func localStartNode(_ *cobra.Command, args []string) error {
 	}
 
 	if useCustomAvalanchegoVersion != "" {
+		// TODO: we'll have to refactor all these when we consolidate input and flag handling for dependency versioning
+		if err = dependencies.CheckVersionIsOverMin(app, constants.AvalancheGoRepoName, network, useCustomAvalanchegoVersion); err != nil {
+			return err
+		}
 		latestAvagoPreReleaseVersion = false
 		latestAvagoReleaseVersion = false
 	}

pkg/dependencies/min_version.go

@@ -0,0 +1,40 @@
+// Copyright (C) 2022, Ava Labs, Inc. All rights reserved.
+// See the file LICENSE for licensing terms.
+package dependencies
+
+import (
+	"encoding/json"
+	"fmt"
+
+	"golang.org/x/mod/semver"
+
+	"github.com/ava-labs/avalanche-cli/pkg/models"
+
+	"github.com/ava-labs/avalanche-cli/pkg/application"
+	"github.com/ava-labs/avalanche-cli/pkg/constants"
+)
+
+func CheckVersionIsOverMin(app *application.Avalanche, dependencyName string, network models.Network, version string) error {
+	dependencyBytes, err := app.Downloader.Download(constants.CLILatestDependencyURL)
+	if err != nil {
+		return err
+	}
+
+	var parsedDependency models.CLIDependencyMap
+	if err = json.Unmarshal(dependencyBytes, &parsedDependency); err != nil {
+		return err
+	}
+
+	switch dependencyName {
+	case constants.AvalancheGoRepoName:
+		// version has to be at least higher than minimum version specified for the dependency
+		minVersion := parsedDependency.AvalancheGo[network.Name()].MinimumVersion
+		versionComparison := semver.Compare(version, minVersion)
+		if versionComparison == -1 {
+			return fmt.Errorf("minimum version of %s that is supported by CLI is %s, current version provided is %s", dependencyName, minVersion, version)
+		}
+		return nil
+	default:
+		return fmt.Errorf("minimum version check is unsupported %s dependency", dependencyName)
+	}
+}

pkg/dependencies/min_version_test.go

@@ -0,0 +1,96 @@
+// Copyright (C) 2022, Ava Labs, Inc. All rights reserved.
+// See the file LICENSE for licensing terms.
+
+package dependencies
+
+import (
+	"testing"
+
+	"github.com/ava-labs/avalanche-cli/internal/mocks"
+	"github.com/ava-labs/avalanche-cli/pkg/application"
+	"github.com/ava-labs/avalanche-cli/pkg/constants"
+	"github.com/ava-labs/avalanche-cli/pkg/models"
+	"github.com/stretchr/testify/mock"
+	"github.com/stretchr/testify/require"
+)
+
+var testCLIMinVersion = []byte(`{"subnet-evm":"v0.7.3","rpc":39,"avalanchego":{"Local Network":{"latest-version":"v1.13.0", "minimum-version":""},"DevNet":{"latest-version":"v1.13.0", "minimum-version":""},"Fuji":{"latest-version":"v1.13.0", "minimum-version":"v1.13.0-fuji"},"Mainnet":{"latest-version":"v1.13.0", "minimum-version":"v1.13.0"}}}`)
+
+func TestCheckMinDependencyVersion(t *testing.T) {
+	tests := []struct {
+		name              string
+		dependency        string
+		expectedError     bool
+		cliDependencyData []byte
+		customVersion     string
+		network           models.Network
+	}{
+		{
+			name:              "custom avalanchego dependency equal to cli minimum supported version of avalanchego",
+			dependency:        constants.AvalancheGoRepoName,
+			cliDependencyData: testCLIMinVersion,
+			expectedError:     false,
+			customVersion:     "v1.13.0-fuji",
+			network:           models.NewFujiNetwork(),
+		},
+		{
+			name:              "custom avalanchego dependency higher than cli minimum supported version of avalanchego",
+			dependency:        constants.AvalancheGoRepoName,
+			cliDependencyData: testCLIMinVersion,
+			expectedError:     false,
+			customVersion:     "v1.13.0",
+			network:           models.NewFujiNetwork(),
+		},
+		{
+			name:              "custom avalanchego dependency equal to cli minimum supported version of avalanchego",
+			dependency:        constants.AvalancheGoRepoName,
+			cliDependencyData: testCLIMinVersion,
+			expectedError:     false,
+			customVersion:     "v1.13.0-fuji",
+			network:           models.NewFujiNetwork(),
+		},
+		{
+			name:              "custom avalanchego dependency higher than cli minimum supported version of avalanchego",
+			dependency:        constants.AvalancheGoRepoName,
+			cliDependencyData: testCLIMinVersion,
+			expectedError:     false,
+			customVersion:     "v1.13.1",
+			network:           models.NewFujiNetwork(),
+		},
+		{
+			name:              "custom avalanchego dependency lower than cli minimum supported version of avalanchego",
+			dependency:        constants.AvalancheGoRepoName,
+			cliDependencyData: testCLIMinVersion,
+			expectedError:     true,
+			customVersion:     "v1.12.2",
+			network:           models.NewFujiNetwork(),
+		},
+		{
+			name:              "custom avalanchego dependency for network that doesn't have minimum supported version of avalanchego",
+			dependency:        constants.AvalancheGoRepoName,
+			cliDependencyData: testCLIMinVersion,
+			expectedError:     false,
+			customVersion:     "v1.12.2",
+			network:           models.NewLocalNetwork(),
+		},
+	}
+
+	for _, tt := range tests {
+		mockDownloader := &mocks.Downloader{}
+		mockDownloader.On("Download", mock.MatchedBy(func(url string) bool {
+			return url == constants.CLILatestDependencyURL
+		})).Return(tt.cliDependencyData, nil)
+
+		app := application.New()
+		app.Downloader = mockDownloader
+
+		t.Run(tt.name, func(t *testing.T) {
+			err := CheckVersionIsOverMin(app, tt.dependency, tt.network, tt.customVersion)
+			if tt.expectedError {
+				require.Error(t, err)
+			} else {
+				require.NoError(t, err)
+			}
+		})
+	}
+}

pkg/models/compatibility.go

@@ -10,7 +10,8 @@ type VMCompatibility struct {
 type AvagoCompatiblity map[string][]string
 
 type NetworkVersion struct {
-	LatestVersion string `json:"latest-version"`
+	LatestVersion  string `json:"latest-version"`
+	MinimumVersion string `json:"minimum-version"`
 }
 
 type CLIDependencyMap struct {

versions/latest.json

@@ -4,23 +4,19 @@
   "avalanchego": {
     "Local Network": {
       "latest-version": "v1.13.0",
-      "require-prerelease": false,
-      "prerelease-version": ""
+      "minimum-version": ""
     },
     "DevNet": {
       "latest-version": "v1.13.0",
-      "require-prerelease": false,
-      "prerelease-version": ""
+      "minimum-version": ""
     },
     "Fuji": {
       "latest-version": "v1.13.0",
-      "require-prerelease": false,
-      "prerelease-version": ""
+      "minimum-version": "v1.13.0-fuji"
     },
     "Mainnet": {
       "latest-version": "v1.13.0",
-      "require-prerelease": false,
-      "prerelease-version": ""
+      "minimum-version": "v1.13.0"
     }
   }
 }