Conversation
Signed-off-by: sukantoraymond <rsukanto@umich.edu>
Signed-off-by: sukantoraymond <rsukanto@umich.edu>
sukantoraymond
requested review from
artemanosov,
cwend-ava and
meaghanfitzgerald
|
As I am working through this PR, I realized that we don't even need subnet-evm version defined in sidecar.json. The benefit to this approach is that we avoid an issue where a blockchain's Subnet EVM has been upgraded, but not reflected in local sidecar, and when we try to sync to that blockchain, we will install the incorrect version of Subnet-EVM |
Signed-off-by: sukantoraymond <rsukanto@umich.edu>
Signed-off-by: sukantoraymond <rsukanto@umich.edu>
Signed-off-by: sukantoraymond <rsukanto@umich.edu>
felipemadero
left a comment
felipemadero
left a comment
There was a problem hiding this comment.
please add the min check to create also
| ) | ||
| if sc.VM == models.SubnetEvm { | ||
| if err = dependencies.CheckVersionIsOverMin(app, constants.SubnetEVMRepoName, networkModel, sc.VMVersion); err != nil { | ||
| ux.Logger.PrintToUser(dependencies.UpdateSubnetEVMInstruction) |
felipemadero
left a comment
felipemadero
left a comment
There was a problem hiding this comment.
preapproving. please address comment
2 participants
Provides minimum version check for Subnet-EVM.
Currently Subnet EVM's version is set during
blockchain create, where we get latest version of subnet-evm by default and write it to sidecar.VMVersion value.We only use Subnet-EVM value when we try to sync local machine / a remote node to a Blockchain. At this stage, we check if subnet-evm version defined in sidecar.VMVersion is at least the minimum version of subnet-evm defined in latest.json. If sidecar.VMVersion is lower than min version, then we will return an error asking the user to update
To update the blockchain's Subnet-EVM version, call avalanche blockchain upgrade vm <blockchainName> --config --version <version>