Subnet evm min version check #2740
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| // Copyright (C) 2022, Ava Labs, Inc. All rights reserved. | ||
| // See the file LICENSE for licensing terms. | ||
| package dependencies | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "fmt" | ||
|
|
||
| "golang.org/x/mod/semver" | ||
|
|
||
| "github.com/ava-labs/avalanche-cli/pkg/models" | ||
|
|
||
| "github.com/ava-labs/avalanche-cli/pkg/application" | ||
| "github.com/ava-labs/avalanche-cli/pkg/constants" | ||
| ) | ||
|
|
||
| var UpdateSubnetEVMInstruction = "To update the blockchain's Subnet-EVM version, call avalanche blockchain upgrade vm <blockchainName> --config --version <version>" | ||
|
|
||
| func CheckVersionIsOverMin(app *application.Avalanche, dependencyName string, network models.Network, version string) error { | ||
| dependencyBytes, err := app.Downloader.Download(constants.CLILatestDependencyURL) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| var parsedDependency models.CLIDependencyMap | ||
| if err = json.Unmarshal(dependencyBytes, &parsedDependency); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| switch dependencyName { | ||
| case constants.AvalancheGoRepoName: | ||
| // version has to be at least higher than minimum version specified for the dependency | ||
| minVersion := parsedDependency.AvalancheGo[network.Name()].MinimumVersion | ||
| versionComparison := semver.Compare(version, minVersion) | ||
| if versionComparison == -1 { | ||
| return fmt.Errorf("minimum version of %s that is supported by CLI is %s", dependencyName, minVersion) | ||
| } | ||
| return nil | ||
| case constants.SubnetEVMRepoName: | ||
| // version has to be at least higher than minimum version specified for the dependency | ||
| minVersion := parsedDependency.SubnetEVM[network.Name()].MinimumVersion | ||
| versionComparison := semver.Compare(version, minVersion) | ||
| if versionComparison == -1 { | ||
| return fmt.Errorf("minimum version of %s that is supported by CLI is %s", dependencyName, minVersion) | ||
| } | ||
| return nil | ||
| default: | ||
| return fmt.Errorf("can't check minimum version for dependency: %s", dependencyName) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| // Copyright (C) 2022, Ava Labs, Inc. All rights reserved. | ||
| // See the file LICENSE for licensing terms. | ||
|
|
||
| package dependencies | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/ava-labs/avalanche-cli/internal/mocks" | ||
| "github.com/ava-labs/avalanche-cli/pkg/application" | ||
| "github.com/ava-labs/avalanche-cli/pkg/constants" | ||
| "github.com/ava-labs/avalanche-cli/pkg/models" | ||
| "github.com/stretchr/testify/mock" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| var testCLIMinVersion = []byte(`{"subnet-evm":{"Local Network":{"latest-version":"v0.7.3", "minimum-version":""},"DevNet":{"latest-version":"v0.7.3", "minimum-version":""},"Fuji":{"latest-version":"v0.7.3", "minimum-version":"v0.7.2"},"Mainnet":{"latest-version":"v0.7.3", "minimum-version":"v0.7.2"}},"rpc":39,"avalanchego":{"Local Network":{"latest-version":"v1.13.0", "minimum-version":""},"DevNet":{"latest-version":"v1.13.0", "minimum-version":""},"Fuji":{"latest-version":"v1.13.0", "minimum-version":"v1.13.0-fuji"},"Mainnet":{"latest-version":"v1.13.0", "minimum-version":"v1.13.0"}}}`) | ||
|
|
||
| func TestCheckMinDependencyVersion(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| dependency string | ||
| expectedError bool | ||
| cliDependencyData []byte | ||
| customVersion string | ||
| network models.Network | ||
| }{ | ||
| { | ||
| name: "custom avalanchego dependency equal to cli minimum supported version of avalanchego", | ||
| dependency: constants.AvalancheGoRepoName, | ||
| cliDependencyData: testCLIMinVersion, | ||
| expectedError: false, | ||
| customVersion: "v1.13.0-fuji", | ||
| network: models.NewFujiNetwork(), | ||
| }, | ||
| { | ||
| name: "custom avalanchego dependency higher than cli minimum supported version of avalanchego", | ||
| dependency: constants.AvalancheGoRepoName, | ||
| cliDependencyData: testCLIMinVersion, | ||
| expectedError: false, | ||
| customVersion: "v1.13.0", | ||
| network: models.NewFujiNetwork(), | ||
| }, | ||
| { | ||
| name: "custom avalanchego dependency higher than cli minimum supported version of avalanchego", | ||
| dependency: constants.AvalancheGoRepoName, | ||
| cliDependencyData: testCLIMinVersion, | ||
| expectedError: false, | ||
| customVersion: "v1.13.1", | ||
| network: models.NewFujiNetwork(), | ||
| }, | ||
| { | ||
| name: "custom avalanchego dependency lower than cli minimum supported version of avalanchego", | ||
| dependency: constants.AvalancheGoRepoName, | ||
| cliDependencyData: testCLIMinVersion, | ||
| expectedError: true, | ||
| customVersion: "v1.12.2", | ||
| network: models.NewFujiNetwork(), | ||
| }, | ||
| { | ||
| name: "custom avalanchego dependency for network that doesn't have minimum supported version of avalanchego", | ||
| dependency: constants.AvalancheGoRepoName, | ||
| cliDependencyData: testCLIMinVersion, | ||
| expectedError: false, | ||
| customVersion: "v1.12.2", | ||
| network: models.NewLocalNetwork(), | ||
| }, | ||
| { | ||
| name: "custom subnetEVM dependency equal to cli minimum supported version of subnetEVM", | ||
| dependency: constants.SubnetEVMRepoName, | ||
| cliDependencyData: testCLIMinVersion, | ||
| expectedError: false, | ||
| customVersion: "v0.7.2", | ||
| network: models.NewFujiNetwork(), | ||
| }, | ||
| { | ||
| name: "custom subnetEVM dependency higher than cli minimum supported version of subnetEVM", | ||
| dependency: constants.SubnetEVMRepoName, | ||
| cliDependencyData: testCLIMinVersion, | ||
| expectedError: false, | ||
| customVersion: "v0.7.3", | ||
| network: models.NewFujiNetwork(), | ||
| }, | ||
| { | ||
| name: "custom subnetEVM dependency lower than cli minimum supported version of subnetEVM", | ||
| dependency: constants.SubnetEVMRepoName, | ||
| cliDependencyData: testCLIMinVersion, | ||
| expectedError: true, | ||
| customVersion: "v0.7.1", | ||
| network: models.NewFujiNetwork(), | ||
| }, | ||
| { | ||
| name: "custom subnetEVM dependency for network that doesn't have minimum supported version of subnetEVM", | ||
| dependency: constants.SubnetEVMRepoName, | ||
| cliDependencyData: testCLIMinVersion, | ||
| expectedError: false, | ||
| customVersion: "v0.7.1", | ||
| network: models.NewLocalNetwork(), | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| mockDownloader := &mocks.Downloader{} | ||
| mockDownloader.On("Download", mock.MatchedBy(func(url string) bool { | ||
| return url == constants.CLILatestDependencyURL | ||
| })).Return(tt.cliDependencyData, nil) | ||
|
|
||
| app := application.New() | ||
| app.Downloader = mockDownloader | ||
|
|
||
| t.Run(tt.name, func(t *testing.T) { | ||
| err := CheckVersionIsOverMin(app, tt.dependency, tt.network, tt.customVersion) | ||
| if tt.expectedError { | ||
| require.Error(t, err) | ||
| } else { | ||
| require.NoError(t, err) | ||
| } | ||
| }) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,39 @@ | ||
| { | ||
| "subnet-evm": { | ||
| "Local Network": { | ||
| "latest-version": "v0.7.3", | ||
| "minimum-version": "" | ||
| }, | ||
| "DevNet": { | ||
| "latest-version": "v0.7.3", | ||
| "minimum-version": "" | ||
| }, | ||
| "Fuji": { | ||
| "latest-version": "v0.7.3", | ||
| "minimum-version": "v0.7.2" | ||
| }, | ||
| "Mainnet": { | ||
| "latest-version": "v0.7.3", | ||
| "minimum-version": "v0.7.2" | ||
| } | ||
| }, | ||
| "rpc": 39, | ||
| "avalanchego": { | ||
| "Local Network": { | ||
| "latest-version": "v1.13.0", | ||
| "minimum-version": "" | ||
| }, | ||
| "DevNet": { | ||
| "latest-version": "v1.13.0", | ||
| "minimum-version": "" | ||
| }, | ||
| "Fuji": { | ||
| "latest-version": "v1.13.0", | ||
| "minimum-version": "v1.13.0-fuji" | ||
| }, | ||
| "Mainnet": { | ||
| "latest-version": "v1.13.0", | ||
| "minimum-version": "v1.13.0" | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.