Merged
Conversation
Tonix517
requested review from
artemanosov,
cwend-ava,
jasonatran,
learyce,
meaghanfitzgerald and
sukantoraymond
Tonix517
commented
Jun 2, 2025
| "github.com/ava-labs/avalanche-cli/pkg/prompts" | ||
| "github.com/ava-labs/avalanche-cli/pkg/ux" | ||
| "github.com/ava-labs/avalanche-cli/pkg/vm" | ||
| "github.com/ava-labs/avalanche-cli/tests/e2e/utils" |
Author
There was a problem hiding this comment.
this will cause cyclic dependency issue. also test code should not be included in prod code
Tonix517
force-pushed
the
tonyz/move_cmd_group_const_to_cmd
branch
from
4194676 to
483e301
Compare
jasonatran
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
To address this suggestion: https://github.com/ava-labs/avalanche-cli/pull/2784/files#r2077889837
How this works
How this was tested
How is this documented