Adding localnetwork e2e tests: start\status\clean by Tonix517 · Pull Request #2784 · ava-labs/avalanche-cli

Tonix517 · 2025-05-01T18:40:50Z

Why this should be merged

https://ava-labs.atlassian.net/browse/DPTN-1625
https://ava-labs.atlassian.net/browse/DPTN-1626
https://ava-labs.atlassian.net/browse/DPTN-1627

How this works

How this was tested

ran new e2e test cases locally

Code Coverage Enhancement:

FULL: 41.5% -> 41.7%
Non-Cloud: 53.7% -> 53.9%
Non-Cloud Non-SDK: 55.3% -> 55.5%

artemanosov

LGTM but would refactor to use new testing function

tests/e2e/testcases/network/start/suite.go

tests/e2e/commands/network.go

sukantoraymond · 2025-05-02T14:57:49Z

tests/e2e/testcases/network/start/suite.go

+	ginkgo.AfterEach(func() {
+		_, _ = commands.CleanNetwork()
+	})
+


can we add tests for these flags too

cmd.Flags().StringVar( &startFlags.UserProvidedAvagoVersion, "avalanchego-version", constants.DefaultAvalancheGoVersion, "use this version of avalanchego (ex: v1.17.12)", ) cmd.Flags().StringVar(&startFlags.AvagoBinaryPath, "avalanchego-path", "", "use this avalanchego binary path") cmd.Flags().StringVar(&startFlags.RelayerBinaryPath, "relayer-path", "", "use this relayer binary path") cmd.Flags().StringVar(&startFlags.SnapshotName, "snapshot-name", constants.DefaultSnapshotName, "name of snapshot to use to start the network from") cmd.Flags().StringVar( &startFlags.RelayerVersion, "relayer-version", constants.DefaultRelayerVersion, "use this relayer version", )

For relayer related tests, feel free to create issue for it / if you want to pick it up, @felipemadero can give more context

ok i just created a ticket for it: https://ava-labs.atlassian.net/browse/DPTN-1665 - will address it in a follow-up PR

what about the other flags;

cmd.Flags().StringVar( &startFlags.UserProvidedAvagoVersion, "avalanchego-version", constants.DefaultAvalancheGoVersion, "use this version of avalanchego (ex: v1.17.12)", ) cmd.Flags().StringVar(&startFlags.AvagoBinaryPath, "avalanchego-path", "", "use this avalanchego binary path") cmd.Flags().StringVar(&startFlags.SnapshotName, "snapshot-name", constants.DefaultSnapshotName, "name of snapshot to use to start the network from")

all added in

tests/e2e/testcases/network/clean/suite.go

tests/e2e/utils/command.go

tests/e2e/commands/network.go

tests/e2e/testcases/network/start/suite.go

felipemadero · 2025-05-07T15:29:57Z

tests/e2e/testcases/network/start/suite.go

+		gomega.Expect(err).Should(gomega.BeNil())
+		gomega.Expect(out).Should(gomega.ContainSubstring("Network is Up"))
+	})
+})


you need to add tests for starting from a stopped cluster. most important test
consideration is that the state is preserved. eg:
start with N nodes -> stop -> start with no args-> the same N is obtained

and check that L1s are started, blockchain deploy -> stop -> start -> the L1s are up and running

also check for start with different snapshot names, and see that:

it does not modify or create a default snapshot

stop only restores that state if given that snapshot name
also, clean only affects the default snapshot, no other snapshots
all the snapshots semantic may be well tested in this commands, together with stop

felipemadero · 2025-05-07T15:33:35Z

tests/e2e/testcases/network/status/suite.go

+	})
+
+	ginkgo.It("can get status of started network", func() {
+		out := commands.StartNetwork()


can you check the status is current for different network configurations, and for deployed L1s?

tests/e2e/testcases/network/status/suite.go

felipemadero · 2025-05-07T15:35:07Z

tests/e2e/testcases/network/stop/suite.go

+var _ = ginkgo.Describe("[Local Network] Stop", ginkgo.Ordered, func() {
 	ginkgo.AfterEach(func() {
-		commands.CleanNetwork()
+		_, _ = commands.CleanNetwork()


I should add here a test case for stopping a locally deployed L1. it should both stop the network and
the L1s

felipemadero · 2025-12-22T13:17:42Z

Closing as CLI is moving into maintenance mode. Thanks for the work on this!

Tonix517 requested a review from a team as a code owner May 1, 2025 18:40

Tonix517 requested review from artemanosov, cwend-ava, jasonatran, learyce, meaghanfitzgerald and sukantoraymond May 1, 2025 18:40

github-actions bot assigned Tonix517 May 1, 2025

artemanosov reviewed May 1, 2025

View reviewed changes

tests/e2e/testcases/network/start/suite.go Show resolved Hide resolved

tests/e2e/commands/network.go Outdated Show resolved Hide resolved

sukantoraymond reviewed May 2, 2025

View reviewed changes

tests/e2e/testcases/network/clean/suite.go Show resolved Hide resolved

Tonix517 force-pushed the tonyz/add_more_local_network_tests branch from 6e94b79 to cbaf8a2 Compare May 2, 2025 18:10

Tonix517 mentioned this pull request May 5, 2025

[DPTN-1653] Adding e2e test for local node start #2792

Closed

1 task

felipemadero reviewed May 7, 2025

View reviewed changes

Tonix517 force-pushed the tonyz/add_more_local_network_tests branch 6 times, most recently from 780d920 to 7a6e648 Compare June 4, 2025 22:21

Tonix517 force-pushed the tonyz/add_more_local_network_tests branch 2 times, most recently from 78f3e1d to 9f8b08e Compare June 11, 2025 21:39

Tonix517 mentioned this pull request Jun 11, 2025

Deprecating --hard option in network clean command #2849

Merged

Tonix517 force-pushed the tonyz/add_more_local_network_tests branch 7 times, most recently from 0a78c42 to a1a9cfc Compare June 12, 2025 22:25

Tonix517 force-pushed the tonyz/add_more_local_network_tests branch 2 times, most recently from b810447 to ab9cc87 Compare June 12, 2025 22:38

Tony Zhang added 4 commits July 9, 2025 11:57

Adding localnetwork e2e tests: start\status\clean

0783f36

Using TestCommand in network e2e commands

6d34df3

adding network hardclean e2e test

dcb0a66

adding back cleannetworkhard cmd

b34301d

Tonix517 force-pushed the tonyz/add_more_local_network_tests branch from ab9cc87 to 2f2bf94 Compare July 9, 2025 18:57

Tonix517 force-pushed the tonyz/add_more_local_network_tests branch from 2f2bf94 to 8716cb3 Compare July 16, 2025 22:24

addressing comments

b786ffb

Tonix517 force-pushed the tonyz/add_more_local_network_tests branch 5 times, most recently from 9f6828a to 32f76ea Compare July 18, 2025 20:15

adding more test cases per feedback

68c727a

Tonix517 force-pushed the tonyz/add_more_local_network_tests branch from 32f76ea to 68c727a Compare July 18, 2025 20:22

felipemadero closed this Dec 22, 2025

Comments

Conversation

Tonix517 commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why this should be merged

How this works

How this was tested

Uh oh!

artemanosov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sukantoraymond May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

felipemadero commented Dec 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Tonix517 commented May 1, 2025 •

edited

Loading

sukantoraymond May 2, 2025 •

edited

Loading