Skip to content

Restrict benchmark auto-push to scheduled runs only#5032

Merged
aaronbuchwald merged 2 commits intomasterfrom
aaronbuchwald/restrict-benchmark-auto-push
Feb 27, 2026
Merged

Restrict benchmark auto-push to scheduled runs only#5032
aaronbuchwald merged 2 commits intomasterfrom
aaronbuchwald/restrict-benchmark-auto-push

Conversation

@aaronbuchwald
Copy link
Collaborator

Summary

  • Restrict gh-pages benchmark auto-push to only schedule events, removing the workflow_dispatch path
  • Prevents one-off manual dispatch runs from creating permanent stale graph entries on the benchmark dashboard

Context

We just purged 45 stale benchmark entries from gh-pages (see #5031) that were created by manual workflow_dispatch runs with non-standard runners/configs. The previous condition:

push-github-action-benchmark: ${{ (github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && github.repository == 'ava-labs/avalanchego' && github.ref_name == 'master')) && matrix.firewood-ref == '' }}

allowed any workflow_dispatch on master to permanently push results to gh-pages, even when using ad-hoc runners (io2-xfast-10ti, i4i-2xlarge) or configs (firewood, firewood-archive) that aren't in the scheduled matrix.

The new condition:

push-github-action-benchmark: ${{ github.event_name == 'schedule' }}

ensures only codified scheduled benchmark configurations produce persistent tracking data. Manual dispatch runs still execute and produce artifacts/PR comments — they just don't write to gh-pages.

Test plan

  • Verify scheduled workflow runs still auto-push (condition is github.event_name == 'schedule')
  • Verify manual workflow_dispatch runs no longer auto-push
  • Verify PR-triggered runs still skip auto-push (unchanged behavior)

🤖 Generated with Claude Code

@aaronbuchwald aaronbuchwald requested a review from a team as a code owner February 26, 2026 22:09
Copilot AI review requested due to automatic review settings February 26, 2026 22:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR ensures benchmark results are only auto-pushed to gh-pages during scheduled workflow runs, preventing manually dispatched benchmark runs (which may use ad-hoc runners/configs) from creating persistent/stale entries on the benchmark dashboard.

Changes:

  • Update push-github-action-benchmark gating to github.event_name == 'schedule' in the GH-native workflow.
  • Update push-github-action-benchmark gating to github.event_name == 'schedule' in the container workflow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/c-chain-reexecution-benchmark-gh-native.yml Restricts benchmark auto-push behavior to scheduled runs only.
.github/workflows/c-chain-reexecution-benchmark-container.yml Restricts benchmark auto-push behavior to scheduled runs only.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Previously, workflow_dispatch runs on master also auto-pushed
benchmark results to gh-pages. This allowed one-off manual runs
with arbitrary runners/configs to create permanent graph entries
on the benchmark dashboard, cluttering it with near-empty graphs
that would never receive new data points.

Restrict auto-push to only schedule events so that only codified
benchmark configurations in the schedule matrix produce persistent
tracking data.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@aaronbuchwald aaronbuchwald force-pushed the aaronbuchwald/restrict-benchmark-auto-push branch from 010fdd1 to 20669e6 Compare February 27, 2026 20:46
@aaronbuchwald aaronbuchwald added this pull request to the merge queue Feb 27, 2026
Merged via the queue into master with commit 7459909 Feb 27, 2026
53 checks passed
@aaronbuchwald aaronbuchwald deleted the aaronbuchwald/restrict-benchmark-auto-push branch February 27, 2026 21:22
@github-project-automation github-project-automation bot moved this to Done 🎉 in avalanchego Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done 🎉

Development

Successfully merging this pull request may close these issues.

4 participants