Restrict benchmark auto-push to scheduled runs only#5032
Merged
aaronbuchwald merged 2 commits intomasterfrom Feb 27, 2026
Merged
Restrict benchmark auto-push to scheduled runs only#5032aaronbuchwald merged 2 commits intomasterfrom
aaronbuchwald merged 2 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures benchmark results are only auto-pushed to gh-pages during scheduled workflow runs, preventing manually dispatched benchmark runs (which may use ad-hoc runners/configs) from creating persistent/stale entries on the benchmark dashboard.
Changes:
- Update
push-github-action-benchmarkgating togithub.event_name == 'schedule'in the GH-native workflow. - Update
push-github-action-benchmarkgating togithub.event_name == 'schedule'in the container workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/c-chain-reexecution-benchmark-gh-native.yml | Restricts benchmark auto-push behavior to scheduled runs only. |
| .github/workflows/c-chain-reexecution-benchmark-container.yml | Restricts benchmark auto-push behavior to scheduled runs only. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maru-ava
approved these changes
Feb 27, 2026
Elvis339
approved these changes
Feb 27, 2026
Previously, workflow_dispatch runs on master also auto-pushed benchmark results to gh-pages. This allowed one-off manual runs with arbitrary runners/configs to create permanent graph entries on the benchmark dashboard, cluttering it with near-empty graphs that would never receive new data points. Restrict auto-push to only schedule events so that only codified benchmark configurations in the schedule matrix produce persistent tracking data. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
010fdd1 to
20669e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scheduleevents, removing theworkflow_dispatchpathContext
We just purged 45 stale benchmark entries from gh-pages (see #5031) that were created by manual
workflow_dispatchruns with non-standard runners/configs. The previous condition:allowed any
workflow_dispatchon master to permanently push results to gh-pages, even when using ad-hoc runners (io2-xfast-10ti,i4i-2xlarge) or configs (firewood,firewood-archive) that aren't in the scheduled matrix.The new condition:
ensures only codified scheduled benchmark configurations produce persistent tracking data. Manual dispatch runs still execute and produce artifacts/PR comments — they just don't write to gh-pages.
Test plan
github.event_name == 'schedule')workflow_dispatchruns no longer auto-push🤖 Generated with Claude Code