Skip to content

CP-12732 Portfolio - Token Price Sorting Not Working Correctly #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bartosz-the-coder-at-avalabs merged 1 commit into from
Jan 9, 2026
Merged

CP-12732 Portfolio - Token Price Sorting Not Working Correctly #655

bartosz-the-coder-at-avalabs merged 1 commit into from
Jan 9, 2026

Conversation

@bartosz-the-coder-at-avalabs
Copy link
Contributor

@bartosz-the-coder-at-avalabs bartosz-the-coder-at-avalabs commented Dec 22, 2025 •
edited
Loading

Description

https://ava-labs.atlassian.net/browse/CP-12732

Changes

Testing

Screenshots:

image

Checklist for the author

Tick each of them when done or if not applicable.

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@bartosz-the-coder-at-avalabs bartosz-the-coder-at-avalabs changed the base branch from main to next-gen/code-freeze-fixes December 22, 2025 17:33
@csabbee
Copy link
Contributor

csabbee commented Dec 29, 2025 •
edited
Loading

hmm so why are we removing this? 🤔
It was not working at any point so there is nothing to fix?

@bartosz-the-coder-at-avalabs
Copy link
Contributor Author

bartosz-the-coder-at-avalabs commented Jan 7, 2026 •
edited
Loading

hmm so why are we removing this? 🤔 It was not working at any point so there is nothing to fix?

Because the AC says so:
image

😛

@csabbee
Copy link
Contributor

csabbee commented Jan 7, 2026

hmm so why are we removing this? 🤔 It was not working at any point so there is nothing to fix?

Because the AC says so: image

😛

Oops 🤦

@bartosz-the-coder-at-avalabs
fix(portfolio): remove sort options
95dd011 
 Token Price and Quantity
@bartosz-the-coder-at-avalabs bartosz-the-coder-at-avalabs merged commit 53fed1e into next-gen/code-freeze-fixes Jan 9, 2026
3 checks passed
@bartosz-the-coder-at-avalabs bartosz-the-coder-at-avalabs deleted the fix/ng/CP-12732 branch January 9, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meeh0w meeh0w meeh0w approved these changes

@csabbee csabbee csabbee approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bartosz-the-coder-at-avalabs @csabbee @meeh0w