Skip to content

CP-12732 Portfolio - Token Price Sorting Not Working Correctly #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartosz-the-coder-at-avalabs merged 1 commit into from
Jan 9, 2026
Merged

CP-12732 Portfolio - Token Price Sorting Not Working Correctly #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions apps/next/src/localization/locales/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,6 @@
"Protocol": "Protocol",
"Provider": "Provider",
"Public key not found": "Public key not found",
"Quantity": "Quantity",
"Quote includes an {{coreFee}} Core fee": "Quote includes an {{coreFee}} Core fee",
"RPC URL": "RPC URL",
"RPC URL reset successfully": "RPC URL reset successfully",
Expand Down Expand Up @@ -789,7 +788,6 @@
"Token Added": "Token Added",
"Token Decimals": "Token Decimals",
"Token Name": "Token Name",
"Token Price": "Token Price",
"Token already exists in the wallet.": "Token already exists in the wallet.",
"Token contract address": "Token contract address",
"Token name": "Token name",
Expand Down
7 changes: 2 additions & 5 deletions ...ges/Portfolio/components/PortfolioHome/components/PortolioDetails/components/SortMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import { PopoverItem } from '@avalabs/k2-alpine';
import { DropdownMenu } from '@/components/DropdownMenu';
import { Box, PopoverItem } from '@avalabs/k2-alpine';
import { FC } from 'react';
import { useTranslation } from 'react-i18next';
import { AssetSortOption } from '../utils/assetSorting';
import { DropdownMenu } from '@/components/DropdownMenu';
import { Box } from '@avalabs/k2-alpine';

export type SortMenuProps = {
id: string;
Expand All @@ -19,8 +18,6 @@ export const SortMenu: FC<SortMenuProps> = ({ id, sort, onSortChange }) => {
{ label: t('Balance'), value: 'balance' },
{ label: t('Name A to Z'), value: 'name-asc' },
{ label: t('Name Z to A'), value: 'name-desc' },
{ label: t('Quantity'), value: 'balance-quantity' },
{ label: t('Token Price'), value: 'token-price' },
];

return (
Expand Down