chore(core/types): remove block.go and import Block and Body from libevm (6)
#760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/core/types/body-libevm
branch
from
2be5a7b to
87f5043
Compare
qdm12
changed the title
Body libevm RLP codec hooks
2 tasks
qdm12
changed the base branch from
libevm-upstream-types
to
qdm12/core/types/header-copy-hooks
qdm12
force-pushed
the
qdm12/core/types/header-copy-hooks
branch
2 times, most recently
from
da83d82 to
58f1171
Compare
qdm12
force-pushed
the
qdm12/core/types/body-libevm
branch
2 times, most recently
from
9978144 to
7027a42
Compare
qdm12
force-pushed
the
qdm12/core/types/body-libevm
branch
2 times, most recently
from
53eb228 to
d65a0d2
Compare
qdm12
force-pushed
the
qdm12/core/types/header-copy-hooks
branch
2 times, most recently
from
3593f92 to
1daa313
Compare
qdm12
changed the title
Body libevm RLP codec hooksBody RLP codec hooks (5)
qdm12
force-pushed
the
qdm12/core/types/header-copy-hooks
branch
3 times, most recently
from
da70431 to
3ff7dea
Compare
qdm12
force-pushed
the
qdm12/core/types/body-libevm
branch
from
d65a0d2 to
787b67d
Compare
qdm12
force-pushed
the
qdm12/core/types/header-copy-hooks
branch
from
3ff7dea to
783edc9
Compare
qdm12
force-pushed
the
qdm12/core/types/body-libevm
branch
2 times, most recently
from
bb94d07 to
3c3ee20
Compare
qdm12
force-pushed
the
qdm12/core/types/header-copy-hooks
branch
from
bb303d6 to
dc264fe
Compare
qdm12
force-pushed
the
qdm12/core/types/body-libevm
branch
3 times, most recently
from
e877b8e to
382b527
Compare
qdm12
force-pushed
the
qdm12/core/types/header-copy-hooks
branch
from
dc264fe to
b999d7c
Compare
qdm12
changed the title
Body RLP codec hooks (5)Body and Block RLP and copy hooks (5)
qdm12
force-pushed
the
qdm12/core/types/body-libevm
branch
2 times, most recently
from
825adad to
ff1e5bd
Compare
qdm12
force-pushed
the
qdm12/core/types/body-libevm
branch
from
a770faa to
37797f0
Compare
|
Last force push adding missing commit pgp signatures on a few commits, sorry about that, I'll recheck my settings. |
darioush
approved these changes
Feb 28, 2025
qdm12
changed the title
Body and Block RLP and copy hooks (6)Block and Body from libevm (6)
ARR4N
approved these changes
Feb 28, 2025
ARR4N
added a commit
that referenced
this pull request
Mar 10, 2025
… libevm (#760) - `BlockBodyExtra` extra payload defined for both `Block` and `Body` - hook `Copy` to be used in `Block` methods `Body`, `WithSeal`, `WithBody` and `WithWithdrawals` - hooks `BlockRLPFieldsForEncoding` and `BlockRLPFieldsForDecoding` for RLP codec of `Block` - hooks `BodyRLPFieldsForEncoding` and `BodyRLPFieldsForDecoding` for RLP codec of `Body` - `SetBlockExtra` to set an extra payload `BlockBodyExtra` on a `Block` - `SetBodyExtra` to set an extra payload `BlockBodyExtra` on a `Body` - Block getter pure functions for extra fields: `BlockExtDataGasUsed`, `BlockGasCost`, `BlockExtData`, `BlockVersion`, `BlockExtDataGasUsed`, `BlockGasCost` - New import from libevm's `core/types`: `Block`, `Blocks`, `Body`, `CalcUncleHash`, `NewBlock` and `NewBlockWithHeader` - remove now unneeded `core/types/block.go` - add test dependency github.com/google/go-cmp v0.7.0 Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 19, 2025
… libevm - `BlockGasCost` getter pure function - New import from libevm's `core/types`: `Block`, `Blocks`, `Body`, `CalcUncleHash`, `NewBlock` and `NewBlockWithHeader` - remove now unneeded `core/types/block.go` See original PR ava-labs/coreth#760 Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 21, 2025
… libevm - `BlockGasCost` getter pure function - New import from libevm's `core/types`: `Block`, `Blocks`, `Body`, `CalcUncleHash`, `NewBlock` and `NewBlockWithHeader` - remove now unneeded `core/types/block.go` See original PR ava-labs/coreth#760 Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 21, 2025
… libevm - `BlockGasCost` getter pure function - New import from libevm's `core/types`: `Block`, `Blocks`, `Body`, `CalcUncleHash`, `NewBlock` and `NewBlockWithHeader` - remove now unneeded `core/types/block.go` See original PR ava-labs/coreth#760 Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 24, 2025
… libevm - `BlockGasCost` getter pure function - New import from libevm's `core/types`: `Block`, `Blocks`, `Body`, `CalcUncleHash`, `NewBlock` and `NewBlockWithHeader` - remove now unneeded `core/types/block.go` See original PR ava-labs/coreth#760 Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 24, 2025
… libevm - `BlockGasCost` getter pure function - New import from libevm's `core/types`: `Block`, `Blocks`, `Body`, `CalcUncleHash`, `NewBlock` and `NewBlockWithHeader` - remove now unneeded `core/types/block.go` See original PR ava-labs/coreth#760 Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 24, 2025
… libevm - `BlockGasCost` getter pure function - New import from libevm's `core/types`: `Block`, `Blocks`, `Body`, `CalcUncleHash`, `NewBlock` and `NewBlockWithHeader` - remove now unneeded `core/types/block.go` See original PR ava-labs/coreth#760 Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 28, 2025
… libevm - `BlockGasCost` getter pure function - New import from libevm's `core/types`: `Block`, `Blocks`, `Body`, `CalcUncleHash`, `NewBlock` and `NewBlockWithHeader` - remove now unneeded `core/types/block.go` See original PR ava-labs/coreth#760 Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Apr 1, 2025
… libevm - `BlockGasCost` getter pure function - New import from libevm's `core/types`: `Block`, `Blocks`, `Body`, `CalcUncleHash`, `NewBlock` and `NewBlockWithHeader` - remove now unneeded `core/types/block.go` See original PR ava-labs/coreth#760 Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>
node-druidx56y
added a commit
to node-druidx56y/subnet-evm
that referenced
this pull request
Sep 28, 2025
… libevm - `BlockGasCost` getter pure function - New import from libevm's `core/types`: `Block`, `Blocks`, `Body`, `CalcUncleHash`, `NewBlock` and `NewBlockWithHeader` - remove now unneeded `core/types/block.go` See original PR ava-labs/coreth#760 Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Remove core/types/block.go and one step closer to remove core/rawdb entirely
How this works
BlockBodyExtraextra payload defined for bothBlockandBodyCopyto be used inBlockmethodsBody,WithSeal,WithBodyandWithWithdrawalsBlockRLPFieldsForEncodingandBlockRLPFieldsForDecodingfor RLP codec ofBlockBodyRLPFieldsForEncodingandBodyRLPFieldsForDecodingfor RLP codec ofBodySetBlockExtrato set an extra payloadBlockBodyExtraon aBlockSetBodyExtrato set an extra payloadBlockBodyExtraon aBodyBlockExtDataGasUsed,BlockGasCost,BlockExtData,BlockVersion,BlockExtDataGasUsed,BlockGasCostcore/types:Block,Blocks,Body,CalcUncleHash,NewBlockandNewBlockWithHeadercore/types/block.goHow this was tested
Existing and new tests
Need to be documented?
No
Need to update RELEASES.md?
No