-
Notifications
You must be signed in to change notification settings - Fork 159
chore(core/types): remove block.go and import Block
and Body
from libevm (6)
#760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
bd8c78a
feat(core/types): `Body` and `Block` hooks
qdm12 cdd8775
Add tests
qdm12 1deea08
Fix sync/client test TestGetBlocks
qdm12 122356d
Remove exported but only local functions
qdm12 e1154a1
sync/client: has its expectation closer to how it was
qdm12 d5715e3
ethclient: fix setting extras on block in `getBlock`
qdm12 2c9f9e4
core/types: move comment on RLP field differences with geth to rlp en…
qdm12 7ec7bcc
core/types: improve comment on Copy method to have godoc links to met…
qdm12 b1b7b8a
core/types: small simplifications in BlockBodyExtra.Copy method
ARR4N 6e3a2d5
core/types: small simplification for `BlockExtData`
qdm12 a8d090c
core/types: fix comment of BlockRLPFieldsForEncoding
qdm12 0568fb4
core/types: safer and more concise BlockGasCost function
qdm12 7e16659
core/types: use slices.Clone in NewBlockWithExtData
qdm12 817bede
core/types: fix bad commit suggestion
qdm12 64ca33d
core/types: reverting slices.Clone in NewBlockWithExtData
qdm12 6c32a6a
core/types: fix bad suggestion in BlockGasCost
qdm12 d271e39
core/types: revet to use slices.Clone in NewBlockWithExtData
qdm12 0332484
refactor(core/types): body and block hooks tests (#841)
ARR4N 5b0f05c
core/types: revert again to not use slices.Clone in NewBlockWithExtDa…
qdm12 6c81d6d
core/types: add golden data test TestBodyRLP
qdm12 876aaf3
core/types: add golden data test TestBlockRLP
qdm12 aed154c
Fix `TestBlockWithNonZeroFields` by ignoring block fields that cannot…
qdm12 c973e56
core/types: improve comment on body withdrawals field drop
qdm12 50e3adb
core/types: blockWithNonZeroFields uses SetBlockExtra
qdm12 9701624
ethclient: make return statement closer to geth
qdm12 dd6e438
core/types: name ignoreFields var in TestBlockWithNonZeroFields
qdm12 1c3d8c2
to also check unexported fields (for Block)
qdm12 909d843
core/types: `bodyWithNonZeroFields` uses `blockWithNonZeroFields`
qdm12 64c22bf
Merge TestBodyRLP and TestBodyExtraRLP together
qdm12 0c5eca8
core/types: merge TestBlockRLP into TestBlockExtraRLP
qdm12 114fc2a
core/types: TestBlockBody uses constant version and shared extData va…
qdm12 aa0c116
core/types: add comment on nil withdrawals in TestBlockExtraRLP
qdm12 619a51a
core/types: allFieldsSet handles unexported fields in common switch case
qdm12 d335448
core/types: bump values in blockWithNonZeroFields
qdm12 39c516a
core/types: TestBodyExtraRLP re-generates copy of wanted body and extra
qdm12 cc11dba
core/types: TestBlockExtraRLP re-generates copy of wanted block and e…
qdm12 4b6ff48
core/types: allFieldsSet remove ineffective t.Helper()
qdm12 e99a77c
core/types: BlockBodyExtra Copy leaves ExtData to nil if it's nil pre…
qdm12 37797f0
deps: bump go-cmp to v0.7.0
qdm12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.