chore(all): libevm phase 2.5 #820

qdm12 · 2025-02-20T13:25:42Z

Why this should be merged

Libevm phase 2.5, see each commit for details

How this works

⚠️ this should only be ff-only merged in master:

git fetch origin
git checkout master
git merge --ff-only libevm
git push

Remaining items

metrics fixing
⚠️ We should address changes due to PR feedback here in chore(all): final small changes to the libevm branch #862 and squash them in libevm
Update release commit?

How this was tested

CI passing, new tests added

Need to be documented?

Good question?

Need to update RELEASES.md?

Releases.md updated

Co-authored-by: Arran Schlosberg <[email protected]>

…ctness) (#700)

* refactor: params.ChainConfigExtra -> params/extras * remove type alias AvalancheConfig * remove type alias for PrecompileConfig * remove type alias UpgradeConfig * remove type alias network upgrade * seems ok to import ethparams.ChainConfig * remove type aliases * refactor: use `ChainConfig.Hooks().(*ChainConfigExtra)` * move RulesExtra (only struct, keep behavior) * refactor: return extras.RulesExtra from GetRulesExtra * rename extras.RulesExtra -> extras.Rules * rename file * refactor: rename extras.ChainConfigExtra -> extras.ChainConfig * return error if chain config type does not match * nit * comment and style improvements * nit * nit --------- Co-authored-by: Arran Schlosberg <[email protected]>

core/blockchain.go

accounts/abi/bind/base.go

accounts/abi/bind/base_test.go

accounts/abi/bind/bind_extra_test.go

core/test_blockchain.go

core/txpool/blobpool/blobpool_test.go

core/txpool/legacypool/legacypool.go

…r_ext.go (#781) - Move our code from state_processor.go to state_processor_ext.go - Slight modifications to state_processor.go to make it more alike geth master

- Define `core.BlockContext` implementing `contract.ConfigurationBlockContext` (same as subnet-evm) - Use `core.NewBlockContext` to convert `types.Block` and `types.Header` for calls to `core.ApplyUpgrades`

Co-authored-by: Quentin Mc Gaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>

…es (#819) - Sort alphabetically libevm imports in `imports.go` - Move `state_account.go`'s libevm imports to `imports.go` - Move extras registration from `state_account.go` to new file `libevm.go`

- Implement `HeaderExtra` RLP and JSON serialization methods - remove `BlockNonce` - remove `EncodeNonce` - new functions `GetHeaderExtra` and `SetHeaderExtra` - Migrate existing custom `Header` to `HeaderSerializable` in block_ext.go with only `Hash` method for RLP code generation - Rename files gen_header_json.go to gen_header_serializable_json.go - Rename files gen_header_rlp.go to gen_header_serializable_rlp.go Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Quentin Mc Gaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]> Co-authored-by: Ceyhun Onur <[email protected]>

- Implement `PostCopy` header hook - Remove `CopyHeader` and use imported one from libevm Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>

… libevm (#760) - `BlockBodyExtra` extra payload defined for both `Block` and `Body` - hook `Copy` to be used in `Block` methods `Body`, `WithSeal`, `WithBody` and `WithWithdrawals` - hooks `BlockRLPFieldsForEncoding` and `BlockRLPFieldsForDecoding` for RLP codec of `Block` - hooks `BodyRLPFieldsForEncoding` and `BodyRLPFieldsForDecoding` for RLP codec of `Body` - `SetBlockExtra` to set an extra payload `BlockBodyExtra` on a `Block` - `SetBodyExtra` to set an extra payload `BlockBodyExtra` on a `Body` - Block getter pure functions for extra fields: `BlockExtDataGasUsed`, `BlockGasCost`, `BlockExtData`, `BlockVersion`, `BlockExtDataGasUsed`, `BlockGasCost` - New import from libevm's `core/types`: `Block`, `Blocks`, `Body`, `CalcUncleHash`, `NewBlock` and `NewBlockWithHeader` - remove now unneeded `core/types/block.go` - add test dependency github.com/google/go-cmp v0.7.0 Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>

…ior (#790)

- Part of the core/rawdb migration to use libevm - Using libevm `InspectDatabase` - Define options passed to libevm `InspectDatabase`

- Move our own code to `_ext.go` files - Import symbols from libevm in imports.go - Use Block and Body hooks previously implemented Co-authored-by: Arran Schlosberg <[email protected]>

…887) - Previous avalanchego was based on top of v1.12.3, although master branch is based off v1.12.3-name-fortuna - Current avalanchego is now based on top of v1.12.3-name-fortuna.0 - Fix versions.sh to detect avalanchego commit hashes for names with more dashes

- import interfaces from github.com/ava-labs/libevm directly - import `NotFound` error from github.com/ava-labs/libevm directly - Keep our two coreth-specific interfaces at interfaces/interfaces.go

- Metrics enabled corrrectly - Remove config argument from BackendConstructor since it's no longer needed - Export newTimestampCompatError with wrapping function NewTimestampCompatErr - Export rlpHash with wrapping function RLPHash - rlpgen supports type aliases - Better logging

- changes applied from comments on the review of #820 - suggested changes from the review on #828 - add test to check PredicateBytesFromExtra is the inverse of SetPredicateBytesInExtra Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>

qdm12 · 2025-03-28T07:55:37Z

Conflits will be resolved with #898

Changes applied from comments on the review of ava-labs/coreth#820 See original PR ava-labs/coreth#862 Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>

plugin/evm/customtypes/hashing.go

sync/statesync/test_sync.go

Changes applied from comments on the review of ava-labs/coreth#820 See original PR ava-labs/coreth#862 Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>

accounts/abi/bind/bind_extra_test.go

go.mod

Changes applied from comments on the review of ava-labs/coreth#820 See original PR ava-labs/coreth#862 Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>

Darioush Jalali and others added 8 commits November 6, 2024 16:39

use libevm: params, core/vm, eth/tracers/* + some of core/types (#662)

4093a7d

Co-authored-by: Arran Schlosberg <[email protected]>

rename: ethereum/go-ethereum -> ava-labs/libevm (#681)

76724a3

Remove IsProhibited (#682)

fd99641

libevm renaming nits (#683)

d7a7fce

Use upstream statedb (#669)

35736dd

use libevm v1.13.14-0.1.0.rc-2 (#694)

98f84c5

fix passing options to Call (needed for native asset historical corre…

826f074

…ctness) (#700)

qdm12 mentioned this pull request Feb 28, 2025

[WIP] Use libevm instead of go-ethereum #777

Closed

qdm12 commented Mar 5, 2025

View reviewed changes

core/blockchain.go Outdated Show resolved Hide resolved

qdm12 mentioned this pull request Mar 7, 2025

chore(all): final small changes to the libevm branch #862

Merged

qdm12 commented Mar 7, 2025

View reviewed changes

Darioush Jalali and others added 18 commits March 10, 2025 09:57

Merge branch 'master' into libevm (#739)

0c04bd9

depend on libevm not go-ethereum (#742)

26c2828

avoid import of params from plugin/evm/atomic (#743)

d2ae72e

chore(core): split our code from state_processor.go in state_processo…

d30eb15

…r_ext.go (#781) - Move our code from state_processor.go to state_processor_ext.go - Slight modifications to state_processor.go to make it more alike geth master

chore(core/types): remove Blocks's Timestamp() method (#749)

f5c6526

- Define `core.BlockContext` implementing `contract.ConfigurationBlockContext` (same as subnet-evm) - Use `core.NewBlockContext` to convert `types.Block` and `types.Header` for calls to `core.ApplyUpgrades`

chore(all): minimal changes for libevm v1.13.14-0.2.0.rc.3 (#811)

a295e40

Co-authored-by: Quentin Mc Gaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>

Merge branch 'master' into libevm (#812)

96545dc

chore(core/types): code restructure to accomodate future libevm chang…

db1df28

…es (#819) - Sort alphabetically libevm imports in `imports.go` - Move `state_account.go`'s libevm imports to `imports.go` - Move extras registration from `state_account.go` to new file `libevm.go`

Merge branch 'master' into libevm (#821)

7a89e1d

Merge branch 'master' into libevm (#823)

70c125b

remove vmerrs (#829)

c82959b

chore(core/types): Header libevm PostCopy hook (5) (#759)

ab612d2

- Implement `PostCopy` header hook - Remove `CopyHeader` and use imported one from libevm Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]>

chore(core/rawdb): add ExampleInspectDatabase to check custom behav…

ae791c4

…ior (#790)

chore(core/rawdb): InspectDatabase uses libevm (8) (#791)

c35d58c

- Part of the core/rawdb migration to use libevm - Using libevm `InspectDatabase` - Define options passed to libevm `InspectDatabase`

chore(core/rawdb): use libevm core/rawdb (#772)

f38d1e8

- Move our own code to `_ext.go` files - Import symbols from libevm in imports.go - Use Block and Body hooks previously implemented Co-authored-by: Arran Schlosberg <[email protected]>

fix(core/evm): set difficulty post shanghai to 0 (#832)

495f435

qdm12 closed this Mar 25, 2025

qdm12 reopened this Mar 26, 2025

qdm12 mentioned this pull request Mar 26, 2025

chore(deps): bump libevm to v1.13.14-0.2.0.rc.4 #889

Merged

qdm12 and others added 5 commits March 26, 2025 14:08

chore(rawdb): move plugin/evm/rawdb to plugin/evm/customrawdb (#888)

de477e4

chore(interfaces): use upstream code (#883)

86c7df2

- import interfaces from github.com/ava-labs/libevm directly - import `NotFound` error from github.com/ava-labs/libevm directly - Keep our two coreth-specific interfaces at interfaces/interfaces.go

chore(types): move plugin/evm/types to plugin/evm/customtypes (#890)

5f11af7

qdm12 mentioned this pull request Mar 28, 2025

final merge master branch into libevm branch #898

Merged

Merge branch 'master' into libevm

d60e65e

qdm12 changed the title ~~[WIP] chore(all): libevm phase 2.5~~ chore(all): libevm phase 2.5 Mar 28, 2025

qdm12 marked this pull request as ready for review March 28, 2025 07:55

qdm12 requested review from a team and ceyonur as code owners March 28, 2025 07:55

Merge branch 'master' into libevm

0d68be6

alarso16 reviewed Mar 31, 2025

View reviewed changes

plugin/evm/customtypes/hashing.go Show resolved Hide resolved

sync/statesync/test_sync.go Show resolved Hide resolved

alarso16 approved these changes Apr 2, 2025

View reviewed changes

Darioush Jalali and others added 2 commits April 7, 2025 11:22

test(core/genesis): fix UT to be sensitive to SetEthUpgrades (#904)

aacce87

fix(metrics/prometheus): skip GaugeInfo metric types (#910)

7316fd8

darioush reviewed Apr 8, 2025

View reviewed changes

accounts/abi/bind/bind_extra_test.go Show resolved Hide resolved

darioush reviewed Apr 8, 2025

View reviewed changes

go.mod Show resolved Hide resolved

darioush approved these changes Apr 8, 2025

View reviewed changes

darioush added this pull request to the merge queue Apr 10, 2025

qdm12 removed this pull request from the merge queue due to a manual request Apr 10, 2025

qdm12 merged commit 7316fd8 into master Apr 10, 2025
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(all): libevm phase 2.5 #820

chore(all): libevm phase 2.5 #820

Uh oh!

qdm12 commented Feb 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qdm12 commented Mar 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chore(all): libevm phase 2.5 #820

chore(all): libevm phase 2.5 #820

Uh oh!

Conversation

qdm12 commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why this should be merged

How this works

Remaining items

How this was tested

Need to be documented?

Need to update RELEASES.md?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qdm12 commented Mar 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

qdm12 commented Feb 20, 2025 •

edited

Loading