fix(metrics): coreth metrics do not conflict with libevm metrics #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/libevm/metrics-reg
branch
from
13501af to
bb89ae2
Compare
qdm12
changed the title
qdm12
force-pushed
the
qdm12/libevm/metrics-reg
branch
from
bb89ae2 to
328f2e6
Compare
qdm12
commented
Mar 5, 2025
qdm12
changed the title
qdm12
added a commit
to ava-labs/libevm
that referenced
this pull request
Mar 6, 2025
- Avoid conflicts for metrics used both in consumers and in libevm - See ava-labs/coreth#848
2 tasks
- Define global `Registry` in metrics/ - All metrics in coreth uses this registry to avoid potential conflicts - plugin/evm initializeMetrics uses this registry
qdm12
force-pushed
the
qdm12/libevm/metrics-reg
branch
2 times, most recently
from
b190459 to
ce3dfaf
Compare
qdm12
force-pushed
the
qdm12/libevm/metrics-reg
branch
from
ce3dfaf to
fdc7354
Compare
|
Closed in favor of #860 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Direct or indirect imports of libevm packages could execute first (depending on compilation/import oder) and register metrics "in libevm", and the coreth defined global metrics would fail silently at registering.
How this works
Use ava-labs/libevm#159 which:
metrics.New*constructors using their correspondingmetrics.GetOrRegister*function. That way the metrics, whether registered first in coreth or in libevm, are shared between the two, and we don't missing metric changes from the one of the two sides.metrics.GetOrRegisterOrOverrideCounterfunction for metrics defined as counters in coreth but defined as another type (timer) in libevm, such that it unregisters the libevm metric and replaces it with the coreth metric of another type. Note we could, if we want, replace it with justOverrideCounterwhere it would not even attempt to get the already registered metric and check its type, let me know.The side effect is that some tests in warp/ had to be changed a tiny bit to clear metrics, since these are now shared between subtest even after calling a
metrics.New*constructor.How this was tested
CI passing
Need to be documented?
No
Need to update RELEASES.md?
No