chore(accounts/abi/bind): revert accidental changes to TestGetSenderNativeAssetCall #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tip I recommend reviewing the diff between this single commit of this PR and the state of the |
ARR4N
approved these changes
Mar 11, 2025
darioush
approved these changes
Mar 11, 2025
ARR4N
pushed a commit
that referenced
this pull request
Mar 11, 2025
qdm12
added a commit
that referenced
this pull request
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
I've added by mistake a refactor commit (destined for #862) to already-approved #851 (yesterday evening in a rush, normal git push), and squashed merged it (overlooking that erroneous commit) this morning.
This reverses the changes such that these can be reviewed later in #862 where it should be. Kind of important to merge this so the changes for that test won't be associated with the rawdb commit, since it has nothing to do with it.
I also suggest we require approvals on the last commit before merging, but keep the "no need to update branch" (as it is, at least for libevm), to keep it flexible whilst also preventing this kind of problem from happening again 😉How this works
Essentially reverts 2773bbb (squashed with other commits)
How this was tested
Need to be documented?
Need to update RELEASES.md?