fix: use libevm/metrics package
#880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
approved these changes
Mar 20, 2025
ARR4N
changed the title
libevm/metrics packagelibevm/metrics package
qdm12
approved these changes
Mar 24, 2025
darioush
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
#745 migrated to upstream metrics and added
metrics.Enabledinsideplugin/evm. However the flag name is misleading and actually disables metric constructors, thus disabling all metrics.How this works
Uses
libevm/metricsinstead ofgo-ethereum/metricsas ava-labs/libevm#165 enabled constructors by default.How this was tested
New unit test.
Need to be documented?
No
Need to update RELEASES.md?
No