chore: enable metrics by default #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The
metrics.Enabledglobal is misleadingly named and disables constructors, not individual metrics when they're used. This resulted in allava-labs/corethmetrics being no-ops because it was only set totrueafter they were all constructed. As the majority of metrics are globals, they're created during package initialisation so simply settingmetrics.Enabled = truesomewhere incorethisn't a guarantee of ordering. The oldcoreth/metricspackage simply set the global totrueby default.How this works
metrics.Enabled = trueat the point of declaration.How this was tested
Local inspection of metrics on a running binary.