Skip to content

Conversation

@qdm12
Copy link

@qdm12 qdm12 commented Mar 25, 2025

Why this should be merged

The config argument is not used by consumers anymore, see ava-labs/coreth@b94c676 and conversation ava-labs/coreth#820 (comment)

How this works

Removes config argument from DBConstructor

How this was tested

Existing CI passing

@qdm12 qdm12 marked this pull request as ready for review March 25, 2025 07:47
Copy link
Collaborator

@ARR4N ARR4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unsure about this at first but now think that it's (a) YAGNI, and (b) easily reverted.

@qdm12
Copy link
Author

qdm12 commented Mar 25, 2025

TIL YAGNI

@qdm12 qdm12 merged commit 87a2d57 into main Mar 25, 2025
11 checks passed
@qdm12 qdm12 deleted the qdm12/triedb/dbconstructor-no-config branch March 25, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants