Skip to content

chore!(triedb): remove config argument for DBConstructor #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

chore!(triedb): remove config argument for DBConstructor #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions triedb/database.libevm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ type ReaderProvider interface {
}

// A DBConstructor constructs alternative backend-database implementations.
type DBConstructor func(ethdb.Database, *Config) DBOverride
type DBConstructor func(ethdb.Database) DBOverride

// A DBOverride is an arbitrary implementation of a [Database] backend. It MUST
// be either a [HashDB] or a [PathDB].
Expand All @@ -59,7 +59,7 @@ func (db *Database) overrideBackend(diskdb ethdb.Database, config *Config) bool
log.Crit("Database override provided when 'hash' or 'path' mode are configured")
}

db.backend = config.DBOverride(diskdb, config)
db.backend = config.DBOverride(diskdb)
switch db.backend.(type) {
case HashDB:
case PathDB:
Expand Down
2 changes: 1 addition & 1 deletion triedb/database.libevm_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import (

func TestDBOverride(t *testing.T) {
config := &Config{
DBOverride: func(d ethdb.Database, c *Config) DBOverride {
DBOverride: func(d ethdb.Database) DBOverride {
return override{}
},
}
Expand Down
Loading