Skip to content

sync: coreth PR #1127: feat(plugin/evm): ACP-226 - set expected block gas cost to 0 in Granite #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 7, 2025
Merged

sync: coreth PR #1127: feat(plugin/evm): ACP-226 - set expected block gas cost to 0 in Granite #1765

merged 11 commits into from
Oct 7, 2025

Conversation

JonathanOppenheimer
Copy link
Member

@JonathanOppenheimer JonathanOppenheimer commented Oct 1, 2025 •
edited
Loading

Syncs ava-labs/coreth#1127.

  • Requesting Cey for review as he is the original author
  • Requesting Michael for review as he was the first approver.

@JonathanOppenheimer JonathanOppenheimer changed the title Jonathan oppenheimer/sync pr 1127 acp 226 blockgascost sync: coreth PR #1127: feat(plugin/evm): ACP-226 - set expected block gas cost to 0 in Granite #1127 Oct 1, 2025
@JonathanOppenheimer JonathanOppenheimer self-assigned this Oct 1, 2025
@JonathanOppenheimer JonathanOppenheimer marked this pull request as ready for review October 1, 2025 16:53
@JonathanOppenheimer JonathanOppenheimer requested a review from a team as a code owner October 1, 2025 16:53
@JonathanOppenheimer JonathanOppenheimer changed the title sync: coreth PR #1127: feat(plugin/evm): ACP-226 - set expected block gas cost to 0 in Granite #1127 sync: coreth PR #1127: feat(plugin/evm): ACP-226 - set expected block gas cost to 0 in Granite Oct 1, 2025
@JonathanOppenheimer JonathanOppenheimer added the blocked Blocked by another issue or pull request label Oct 1, 2025
@JonathanOppenheimer JonathanOppenheimer marked this pull request as draft October 1, 2025 18:57
@JonathanOppenheimer
Copy link
Member Author

Blocked by #1766

@JonathanOppenheimer JonathanOppenheimer force-pushed the JonathanOppenheimer/sync-pr-1127-acp-226-blockgascost branch from 2180243 to 5fec099 Compare October 2, 2025 14:32
ceyonur and others added 2 commits October 2, 2025 10:36
@ceyonur @powerslider
@alarso16 @StephenButtolph @JonathanOppenheimer
feat(plugin/evm): ACP-226 - set expected block gas cost to 0 in Grani…
a524fbd 
…te (#1127)

Signed-off-by: Tsvetan Dimitrov <[email protected]>
Co-authored-by: Tsvetan Dimitrov <[email protected]>
Co-authored-by: Austin Larson <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]>
@JonathanOppenheimer
adjust for subnet-evm
662bad3
@JonathanOppenheimer JonathanOppenheimer removed the blocked Blocked by another issue or pull request label Oct 2, 2025
@JonathanOppenheimer JonathanOppenheimer marked this pull request as ready for review October 2, 2025 14:54
alarso16
alarso16 requested changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@alarso16 alarso16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops - gotta fix this first

alarso16
alarso16 approved these changes Oct 2, 2025
View reviewed changes
michaelkaplan13
michaelkaplan13 reviewed Oct 2, 2025
View reviewed changes
michaelkaplan13
michaelkaplan13 approved these changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@michaelkaplan13 michaelkaplan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test nit, but otherwise LGTM.

ceyonur
ceyonur requested changes Oct 4, 2025
View reviewed changes
@JonathanOppenheimer JonathanOppenheimer mentioned this pull request Oct 6, 2025
Merged
@ceyonur ceyonur added this pull request to the merge queue Oct 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 7, 2025
@michaelkaplan13 michaelkaplan13 added this pull request to the merge queue Oct 7, 2025
Merged via the queue into master with commit 935680c Oct 7, 2025
13 checks passed
@michaelkaplan13 michaelkaplan13 deleted the JonathanOppenheimer/sync-pr-1127-acp-226-blockgascost branch October 7, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ceyonur ceyonur ceyonur approved these changes

@michaelkaplan13 michaelkaplan13 michaelkaplan13 approved these changes

@alarso16 alarso16 alarso16 approved these changes

Assignees

@JonathanOppenheimer JonathanOppenheimer

Labels

acp226 coreth sync

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JonathanOppenheimer @ceyonur @michaelkaplan13 @alarso16