Open
Conversation
The buspirate logic tries to detect different versions of supported features by the buspirate. One case is that the buspirate does not support paged writes, in this case the pgm->paged_write function pointer is set to NULL. However, the avr_write code unconditionally calls pgm->paged_write and crashes the avrdude. This change checks if the paged_write pointer is still set and falls back to byte-by-byte write if not. This allows for byte-by-byte write, while still using paged_read for verification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The buspirate logic tries to detect different versions of supported features by the buspirate. One case is that the buspirate does not support paged writes, in this case the pgm->paged_write function pointer is set to NULL. However, the avr_write code unconditionally calls pgm->paged_write and crashes the avrdude.
This change checks if the paged_write pointer is still set and falls back to byte-by-byte write if not. This allows for byte-by-byte write, while still using paged_read for verification.