Skip to content

Fix buspirate fallback to byte write #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexwarg wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

Fix buspirate fallback to byte write #2074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/avr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,12 +1122,14 @@ int avr_write_mem(const PROGRAMMER *pgm, const AVRPART *p, const AVRMEM *m, int

if(auto_erase && pgm->page_erase && !mem_is_eeprom(cm))
rc = pgm->page_erase(pgm, p, cm, pageaddr);
if(rc >= 0)
if(pgm->paged_write && (rc >= 0))
rc = pgm->paged_write(pgm, p, cm, cm->page_size, pageaddr, cm->page_size);
if(rc < 0)
if(!pgm->paged_write || (rc < 0))
failure = 1; // Paged write failed, fall back to byte-at-a-time write below
nwritten++;
report_progress(nwritten, npages, NULL);
else {
nwritten++;
report_progress(nwritten, npages, NULL);
}
} else {
pmsg_debug("%s(): skipping page %u: no interesting data\n", __func__, pageaddr/cm->page_size);
}
Expand Down
Loading