Skip to content

Conversation

@vincetran
Copy link
Member

Issue #, if available: N/A

Description of changes: After a callout from Tyler and some additional testing, found that having the challenge option as part of the remembered state for the Composable will break since when the view is rendered, the session ID is considered started and thus can't be reused which is what happens when the Composable gets torn down and restarted. Instead, will have to add a callout to the docs change that developers will need to create a new session ID if they wish to change the camera orientation "on the fly"

How did you test these changes? Tested by attemping to "swap" camera options at runtime at the start view as well as while the liveness check is happening. Before this fix, the Composable would restart and Rekognition would return an exception saying the session is no longer valid. After this fix, attempting to "swap" the option doesn't do anything.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(liveness): message, fix(authenticator): message, fix(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vincetran vincetran requested review from a team as code owners June 26, 2025 06:25
@vincetran vincetran merged commit 7891037 into feature/no-light-sku Jun 26, 2025
1 check passed
@vincetran vincetran deleted the fix/no-light-key branch June 26, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants