Skip to content

Conversation

@michaelhtm
Copy link
Member

Description of changes:

Currently, if the resource output shape is a list, code-gen triggers the
readmany output generator.
When doing so, it does not pass the operationType, which causes it to
lose some of its functionality, which in this case was the ability to
ignore setting resources for a desired method.
With these changes, even sdk outputs that have a list as output type
will be able to configure Create/Update/Delete set config in
generator.yaml

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Currently, if the resource output shape is a list, code-gen triggers the
readmany output generator.
When doing so, it does not pass the operationType, which causes it to
lose some of its functionality, which in this case was the ability to
ignore setting resources for a desired method.
With these changes, even sdk outputs that have a list as output type
will be able to configure Create/Update/Delete set config in
generator.yaml
@ack-prow ack-prow bot requested review from a-hilaly and rushmash91 October 16, 2025 20:24
@ack-prow ack-prow bot added the approved label Oct 16, 2025
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2025
@ack-prow
Copy link

ack-prow bot commented Oct 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michaelhtm
Copy link
Member Author

/retest

@ack-prow
Copy link

ack-prow bot commented Oct 18, 2025

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 0328f60 link false /test verify-attribution
s3-olm-test 0328f60 link false /test s3-olm-test
lambda-controller-test 0328f60 link true /test lambda-controller-test
eks-controller-test 0328f60 link true /test eks-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants