Skip to content

pass optype to setResourceReadMany from SetResource #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pass optype to setResourceReadMany from SetResource #630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pkg/generate/code/set_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ func SetResource(
if op == r.Ops.ReadMany {
return setResourceReadMany(
cfg, r,
op, sourceVarName, targetVarName, indentLevel,
opType, op, sourceVarName, targetVarName, indentLevel,
)
} else if wrapperFieldPath != nil {
// fieldpath api requires fully-qualified path
Expand All @@ -133,7 +133,7 @@ func SetResource(
if sref.Shape.Type == "list" {
return setResourceReadMany(
cfg, r,
op, sourceVarName, targetVarName, indentLevel,
opType, op, sourceVarName, targetVarName, indentLevel,
)
}
}
Expand Down Expand Up @@ -509,6 +509,8 @@ func ListMemberNameInReadManyOutput(
func setResourceReadMany(
cfg *ackgenconfig.Config,
r *model.CRD,
// the operation type
opType model.OpType,
// The ReadMany operation descriptor
op *awssdkmodel.Operation,
// String representing the name of the variable that we will grab the
Expand Down Expand Up @@ -660,7 +662,7 @@ func setResourceReadMany(

// We may have some special instructions for how to handle setting the
// field value...
setCfg := f.GetSetterConfig(model.OpTypeList)
setCfg := f.GetSetterConfig(opType)

if setCfg != nil && setCfg.IgnoreResourceSetter() {
continue
Expand Down