add operations catalog validation #722
Conversation
|
@rushmash91: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
rushmash91
changed the title
| "update_operations": ["UpdateRepository", "ModifyRepository"], | ||
| "create_operations": ["CreateRepository"], | ||
| "read_operations": ["GetRepository"], (prefer "Get" over "Describe") | ||
| "update_operations": ["UpdateRepository"], |
There was a problem hiding this comment.
Should this have a similar "(prefer "Update" over "Modify") hint?
There was a problem hiding this comment.
Usually there is only one update call, READ tends to have read one and read many, but we can never be sure with these. We can add it if we see it missing updates..
| config_path = Path(__file__).parent.parent.parent.parent / "prow" / "jobs" / "jobs_config.yaml" | ||
| config_path = Path(__file__).parent.parent.parent.parent / "jobs" / "jobs_config.yaml" |
There was a problem hiding this comment.
Q: Were you seeing an issue loading this file?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knottnt, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.