chore: add user name character warning#1708
chore: add user name character warning#1708kstribrnAmzn wants to merge 1 commit intoaws-greengrass:mainfrom kstribrnAmzn:usernameWarn
Conversation
src/main/java/com/aws/greengrass/lifecyclemanager/KernelCommandLine.java
Show resolved
Hide resolved
|
To test this change I deployed the nucleus onto a windows instance and attempted to boot it up with the following command Log message seen in the greengrass.log file |
|
LGTM but how are you creating this pull request? Are you creating a fork of this repo and creating a PR out of that? That will not work as it will not be able to run the CI for unit and integ tests. You need clone this repo, create a new branch for your work and create a PR from that. |
Adds a warning log when potentially invalid characters are used in a username.
|
Closing in favor of #1718 since this PR (based off a fork) will not have automated testing performed. |
|
Binary incompatibility detected for commit 6a88a8b. com.aws.greengrass.lifecyclemanager.KernelAlternatives is binary incompatible and is source incompatible because of METHOD_LESS_ACCESSIBLE Produced by binaryCompatability.py |
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 6a88a8b |
|
Integration Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 6a88a8b |
Issue #, if available:
Description of changes:
Adds a warning log when potentially
invalid characters are used in a username.
Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
This change aims to raise awareness around invalid user names which can cause component failures.
For Linux see this (best doc I could find).
For Windows see this.
Documentation Checklist:
Compatibility Checklist:
any deprecated method or type.
Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.