Skip to content

chore: add user name character warning #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kstribrnAmzn wants to merge 1 commit into from
Closed

chore: add user name character warning #1708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/com/aws/greengrass/lifecyclemanager/KernelCommandLine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ public class KernelCommandLine {
private static final String deploymentsPathName = "~root/deployments";
private static final String cliIpcInfoPathName = "~root/cli_ipc_info";
private static final String binPathName = "~root/bin";
private static final String validUserCharExpr = "^[a-zA-Z0-9._]+[a-zA-Z0-9._-]*$";

public KernelCommandLine(Kernel kernel) {
this(kernel, kernel.getNucleusPaths());
Expand Down Expand Up @@ -158,6 +159,10 @@ void updateDeviceConfiguration(DeviceConfiguration deviceConfiguration) {
}
if (defaultUserFromCmdLine != null) {
if (PlatformResolver.isWindows) {
if (!defaultUserFromCmdLine.matches(validUserCharExpr)) {
logger.warn("Component user may contain invalid characters. This can cause issues starting a "
+ "component.");
}
deviceConfiguration.getRunWithDefaultWindowsUser().withValue(defaultUserFromCmdLine);
} else {
deviceConfiguration.getRunWithDefaultPosixUser().withValue(defaultUserFromCmdLine);
Expand Down
Loading