generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 23
Enhance Logs E2E test and bump up MySQL library to 8.4 #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerry-shao
reviewed
Sep 9, 2024
jerry-shao
reviewed
Sep 9, 2024
validator/src/main/resources/expected-data-template/java/eks/rds-mysql-trace.mustache
Outdated
Show resolved
Hide resolved
jerry-shao
reviewed
Sep 10, 2024
validator/src/main/resources/expected-data-template/java/eks/rds-mysql-trace.mustache
Show resolved
Hide resolved
|
LGTM |
majanjua-amzn
approved these changes
Sep 11, 2024
jerry-shao
added a commit
to jerry-shao/aws-application-signals-test-framework
that referenced
this pull request
Sep 12, 2024
…bservability#221)" This reverts commit 3502e73.
majanjua-amzn
pushed a commit
that referenced
this pull request
Sep 12, 2024
jerry-shao
pushed a commit
to jerry-shao/aws-application-signals-test-framework
that referenced
this pull request
Sep 23, 2024
jerry-shao
pushed a commit
to jerry-shao/aws-application-signals-test-framework
that referenced
this pull request
Sep 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description:
In this PR:
remoteResourceTypeandremoteResourceIdentifierfilter when fetching from Logs.E2E test after updating trace template:
E2E test failed run reproduced locally - https://github.com/ektabj/aws-application-signals-test-framework/actions/runs/10771640665/job/29867588349
E2E test run passed after changes: https://github.com/ektabj/aws-application-signals-test-framework/actions/runs/10777657675/job/29887245097
Issue description:
When we assert
RemoteResourceTypeandRemoteResourceIdentifierattributes in EMF logs, we are using Logs filter:RemoteServiceandRemoteOperationfilter to fetch logs. However, it's not guaranteed that EMF log withRemoteServiceandRemoteOperationattributes will haveRemoteResourceTypeandRemoteResourceIdentifier. The logs fetched with this generic filter might get more logs than expected and only asserting the first log event in the result.Description of changes:
This change enhances the log filter by appending
&& ($.RemoteResourceType = %EXAMPLE%) && ($.RemoteResourceIdentifier = %EXAMPLE%)to the filter if they present in the template to get more specific log events.Log Filter doc: https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/FilterAndPatternSyntax.html#regex-expressions
Log Filter used before this change (From E2E testing log):
Log Filter used after this change (From E2E testing log):
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.