Update trace validation to handle multiple ? #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjrara
approved these changes
Jul 2, 2025
harrryr
added a commit
that referenced
this pull request
Jul 3, 2025
*Issue description:* Follow up from this PR: #419 The issue is related to cw agent so all platforms are affected. Adding the REGEX fix to all dotnet validation templates except for adot sigv4 since it does not use cw agent By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description:
For EKS Dotnet tests, there is currently a known issue where there is two
??in the http url instead of the expected one.Temporarily updating the validation tests to be able to handle 0 to 2 questions marks until the issue is fixed.
Test
https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/16010052322/job/45165626309
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.