Skip to content

Conversation

ezhang6811
Copy link
Contributor

Issue #, if available:

Description of changes:
We plan to consolidate our ADOT SDK and Lambda layer releases for future versions. This PR merges the Lambda release workflow into the main release workflow, and publishes the layer artifacts and ARN notes to the same Github release as the SDK.

The release build workflow also now includes the SDK release notes with our upstream dependency versions to eliminate the manual effort needed when updating release notes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ezhang6811 ezhang6811 requested a review from a team as a code owner August 25, 2025 19:45
vastin
vastin previously approved these changes Sep 15, 2025
Copy link
Contributor

@vastin vastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The ADOT .NET build is failing because it can no longer create a Windows Server 2019 container image. According to GitHub, Windows Server 2019 was retired, and its container image was removed on 2025-06-30.
echo "SECRET_KEY=${SECRET_KEY}" >> $GITHUB_ENV
- uses: aws-actions/[email protected]
with:
role-to-assume: ${{ secrets[env.SECRET_KEY] }}

Check warning

Code scanning / CodeQL

Excessive Secrets Exposure Medium

All organization and repository secrets are passed to the workflow runner in
secrets[env.SECRET_KEY]
@ezhang6811 ezhang6811 added the skip changelog doesn't need a CHANGELOG entry label Sep 18, 2025
thpierce added a commit that referenced this pull request Sep 19, 2025
Fixes style issues that kept showing up in PRs (e.g.
#244).
Configure build to fail on warnings to prevent future issues, aligning
with upstream:
https://github.com/search?q=repo%3Aopen-telemetry%2Fopentelemetry-dotnet-instrumentation%20TreatWarningsAsErrors&type=code

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog doesn't need a CHANGELOG entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants