Fixed toString for OtlpAwsSpanExporter #1024
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjrara
reviewed
Mar 10, 2025
| @Override | ||
| public String toString() { | ||
| return this.parentExporter.toString(); | ||
| return this.parentExporter.toString().replace("OtlpHttpSpanExporter", "OtlpAwsSpanExporter"); |
Member
There was a problem hiding this comment.
Why not return a constant value?
Contributor
Author
There was a problem hiding this comment.
I wanted to keep the same toString message as this class:
But override the class name to make it more clear for log messages.
Member
There was a problem hiding this comment.
Can we just copy the code to here?
Contributor
Author
There was a problem hiding this comment.
toString copied in new PR:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Modified the toString method for the SigV4 exporter to say OtlpAwsSpanExporter instead of OtlpHttpSpanExporter.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.