Skip to content

Fixed toString for OtlpAwsSpanExporter #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed toString for OtlpAwsSpanExporter #1024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../src/main/java/software/amazon/opentelemetry/javaagent/providers/OtlpAwsSpanExporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public CompletableResultCode shutdown() {

@Override
public String toString() {
return this.parentExporter.toString();
return this.parentExporter.toString().replace("OtlpHttpSpanExporter", "OtlpAwsSpanExporter");
Copy link
Member

@bjrara bjrara Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not return a constant value?

Copy link
Contributor Author

@liustve liustve Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to keep the same toString message as this class:

https://github.com/open-telemetry/opentelemetry-java/blob/main/exporters/otlp/all/src/main/java/io/opentelemetry/exporter/otlp/http/trace/OtlpHttpSpanExporter.java

But override the class name to make it more clear for log messages.

Copy link
Member

@bjrara bjrara Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just copy the code to here?

Copy link
Contributor Author

@liustve liustve Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toString copied in new PR:

#1046

}

private final class SigV4AuthHeaderSupplier implements Supplier<Map<String, String>> {
Expand Down
Loading