Skip to content

Conversation

@bjrara
Copy link
Member

@bjrara bjrara commented Sep 19, 2024

Feature request

Add runtime metrics collection into Application Signals.

Description of changes:

This PR is an umbrella PR to track the ongoing changes for runtime metrics.

  1. Add Application Signals runtime metrics with feature disabled #900 [Merged in main]
  2. feat: Add contract tests for runtime metrics #893
  3. Enable runtime metrics by default

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bjrara bjrara requested a review from a team as a code owner September 19, 2024 23:06
@bjrara bjrara force-pushed the runtime-feature branch 2 times, most recently from 41be317 to 9da8381 Compare October 16, 2024 03:44
Reno Seo and others added 4 commits October 18, 2024 17:26
*Issue #, if available:*
N/A

*Description of changes:*
This PR adds contract tests for runtime metrics feature, where it
validates:
1. Are all runtime metrics captured?
2. Do the runtime metrics have a realistic value? (non-negative)

These changes can easily be extended for higher coverage in the future.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
@bjrara bjrara changed the title [DO NOT MERGE] Add Application Signals runtime metrics Add Application Signals runtime metrics Oct 24, 2024
Copy link
Contributor

@vastin vastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjrara bjrara merged commit d97972b into main Oct 25, 2024
4 checks passed
@bjrara bjrara deleted the runtime-feature branch October 25, 2024 21:17
@bjrara bjrara mentioned this pull request Oct 31, 2024
bjrara added a commit that referenced this pull request Oct 31, 2024
*Description of changes:*
1. [Switch isEmpty() to .isPresent() for Optionals Type
#939](#939)
1. [Comment out E2E Operator Test
#940](#940)
1. [Add Application Signals runtime metrics
#892](#892)
1. [Update Dockerfile for corretto-slim build
#924](#924)

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Co-authored-by: Michael He <[email protected]>
Co-authored-by: Ping Xiang <[email protected]>
Co-authored-by: Reno Seo <[email protected]>
Co-authored-by: Harry <[email protected]>
Co-authored-by: Min Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants