feat: add support for new cohere command r models #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyuan-he
force-pushed
the
add-command-r-model
branch
from
41663ab to
a3355ea
Compare
yiyuan-he
commented
Nov 6, 2024
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/aws/services/bedrock.ts
Show resolved
Hide resolved
yiyuan-he
commented
Nov 6, 2024
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/aws/services/bedrock.ts
Show resolved
Hide resolved
yiyuan-he
commented
Nov 6, 2024
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/aws/services/bedrock.ts
Show resolved
Hide resolved
yiyuan-he
changed the title
yiyuan-he
force-pushed
the
add-command-r-model
branch
from
ced18cb to
c25d7de
Compare
yiyuan-he
commented
Nov 8, 2024
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/aws/services/bedrock.ts
Show resolved
Hide resolved
mxiamxia
reviewed
Nov 21, 2024
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/aws/services/bedrock.ts
Outdated
Show resolved
Hide resolved
mxiamxia
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adding support for Cohere Command R models. The previous Cohere Command models are not yet fully deprecated (EOL April 2025) so we still include support for now.
Beginning 11/05/24 - Calls to old Cohere Command models now throw an exception for deprecation. I wasn't able to find any official announcement for this change, but I noticed it while testing during development in the Java SDK.
Interestingly, calls to the old model still return a response so the full gen ai attributes are still generated for the time being.
Test Plan:
Verified the attributes for the Command R model is being generated with sample app auto-instrumentation.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.