LLO Handler - Full implementation and tests #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyuan-he
previously approved these changes
Jun 26, 2025
There was a problem hiding this comment.
LGTM thanks!
The changes seem to be in parity with my Python changes. As for copying over the Span Context, agree this is probably not ideal but doing the LLO Handling in the exporter rather than the Span Processor was an intentional design choice that we made at the very beginning so might just be a necessary evil here.
mxiamxia
reviewed
Jun 27, 2025
aws-distro-opentelemetry-node-autoinstrumentation/src/otlp-aws-span-exporter.ts
Show resolved
Hide resolved
mxiamxia
reviewed
Jun 27, 2025
mxiamxia
reviewed
Jun 27, 2025
aws-distro-opentelemetry-node-autoinstrumentation/src/llo-handler.ts
Outdated
Show resolved
Hide resolved
mxiamxia
reviewed
Jun 27, 2025
aws-distro-opentelemetry-node-autoinstrumentation/src/llo-handler.ts
Outdated
Show resolved
Hide resolved
mxiamxia
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
JS equivalent of:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.