Skip to content

LLO Handler - Full implementation and tests #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 27, 2025
Merged

LLO Handler - Full implementation and tests #203

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2acbfe1
LLO Handler - Full implementation and tests
jj22ee Jun 20, 2025
0e0feae
small cleanup
jj22ee Jun 26, 2025
1a83cdf
add getSpanContext test for the custom Context
jj22ee Jun 27, 2025
c0395f9
address comments
jj22ee Jun 27, 2025
091d184
Merge branch 'main' into llo-handler-pr
mxiamxia Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions aws-distro-opentelemetry-node-autoinstrumentation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@
"@opentelemetry/api": "1.9.0",
"@opentelemetry/auto-configuration-propagators": "0.3.2",
"@opentelemetry/auto-instrumentations-node": "0.56.0",
"@opentelemetry/api-events": "0.57.1",
"@opentelemetry/sdk-events": "0.57.1",
"@opentelemetry/sdk-logs": "0.57.1",
"@opentelemetry/core": "1.30.1",
"@opentelemetry/exporter-metrics-otlp-grpc": "0.57.1",
"@opentelemetry/exporter-metrics-otlp-http": "0.57.1",
Expand Down
4 changes: 1 addition & 3 deletions aws-distro-opentelemetry-node-autoinstrumentation/src/aws-metric-attributes-span-exporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
MetricAttributeGenerator,
SERVICE_METRIC,
} from './metric-attribute-generator';
import { Mutable } from './utils';

/**
* This exporter will update a span with metric attributes before exporting. It depends on a
Expand Down Expand Up @@ -125,9 +126,6 @@ export class AwsMetricAttributesSpanExporter implements SpanExporter {
}

// Bypass `readonly` restriction of ReadableSpan's attributes.
// Workaround provided from official TypeScript docs:
// https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-8.html#improved-control-over-mapped-type-modifiers
type Mutable<T> = { -readonly [P in keyof T]: T[P] };
const mutableSpan: Mutable<ReadableSpan> = span;
mutableSpan.attributes = updateAttributes;

Expand Down
Loading