Add Image Scan to PR Build #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpierce
reviewed
Aug 13, 2025
This reverts commit c61274b.
thpierce
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adding
artifacts_buildstep topr-buildworkflow for JS images to get vulnerability scanning during PR builds.See the same for Java and Python
Delete duplicate
docker logoutstep in artifact_build. Doesn't effect PR builds from forked repos:https://github.com/aws-observability/aws-otel-js-instrumentation/actions/runs/16950181911/job/48040937542?pr=251
Testing
Successful run: https://github.com/aws-observability/aws-otel-js-instrumentation/actions/runs/16949767942
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.