Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .github/actions/artifacts_build/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,6 @@ runs:
env:
AWS_REGION: ${{ inputs.aws-region }}

# Per https://docs.aws.amazon.com/AmazonECR/latest/public/docker-pull-ecr-image.html, it is possible to
# make unauthorized calls to get public ECR images (needed to build the ADOT Node docker image), but
# it can fail if you previously authenticated to a public repo. Adding this step to log out, so we
# ensure we can make unauthenticated call. This is important for making the pr_build workflow run on
# PRs created from forked repos.
- name: Logout of public AWS ECR
shell: bash
run: docker logout public.ecr.aws

- name: Build and push image according to input
uses: docker/build-push-action@v5
with:
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/pr-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,15 @@ jobs:
run: npm ci
- name: Compile all NPM projects
run: npm run compile
- name: Build Tarball and Image Files
uses: ./.github/actions/artifacts_build
with:
image_uri_with_tag: pr-build/${{ matrix.node }}
push_image: false
load_image: true
node_version: ${{ matrix.node }}
package_name: aws-distro-opentelemetry-node-autoinstrumentation
os: ubuntu-latest
- name: Build Lambda Layer
run: npm run build-lambda
- name: Unit tests (Full)
Expand Down
Loading