Fix no attributes returned with un-sampled case. #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxiamxia
approved these changes
Sep 10, 2024
wangzlei
approved these changes
Sep 10, 2024
bjrara
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fix the bug: When trace is not sampled, the span attributes is None,
RemoteOperationandRemoteServicebecomes Unknown.Testing:
Before the change:
OTEL_TRACES_SAMPLER=traceidratio OTEL_TRACES_SAMPLER_ARG="0.0":OTEL_TRACES_SAMPLER=xray OTEL_TRACES_SAMPLER_ARG="endpoint=http://localhost:2000"with more than 1 segments per second:After the change:
OTEL_TRACES_SAMPLER=traceidratio OTEL_TRACES_SAMPLER_ARG="0.0":OTEL_TRACES_SAMPLER=xray OTEL_TRACES_SAMPLER_ARG="endpoint=http://localhost:2000"with more than 1 segments per second:By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.